mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Armand Grillet <agril...@mesosphere.io>
Subject Review Request 64683: Updated support/mesos-style.py to build the virtualenv less often.
Date Mon, 18 Dec 2017 18:35:20 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64683/
-----------------------------------------------------------

Review request for mesos, Alexander Rukletsov and Benno Evers.


Bugs: MESOS-8217
    https://issues.apache.org/jira/browse/MESOS-8217


Repository: mesos


Description
-------

Instead of just checking if the virtual environment exists, we now
also check if it is required to lint the modified files or not.

The virtual environment will thus be built when using the script as
a git hook only if JavaScript or Python files have been modified.


Diffs
-----

  support/mesos-style.py 315955e3533fce0cbf820fad03b3707049cdffe0 


Diff: https://reviews.apache.org/r/64683/diff/1/


Testing
-------

Tested the commit hook with multiple combinations and checked that the result was the one
expected.


Thanks,

Armand Grillet


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message