mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Mesos Reviewbot Windows <revi...@mesos.apache.org>
Subject Re: Review Request 64436: Toggled the authenticate_http_readwrite flag in MesosTest.
Date Sat, 16 Dec 2017 01:52:55 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64436/#review194004
-----------------------------------------------------------



PASS: Mesos patch 64436 was successfully built and tested.

Reviews applied: `['64436']`

All the build artifacts available at: http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/64436

- Mesos Reviewbot Windows


On Dec. 16, 2017, 12:45 a.m., James Peach wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/64436/
> -----------------------------------------------------------
> 
> (Updated Dec. 16, 2017, 12:45 a.m.)
> 
> 
> Review request for mesos and Greg Mann.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> The default executor authentication mechanism depends on SSL support
> being enabled in the build. Multiple tests that invoke the default
> executor have compilation time checks for SSL support so they
> can disable the Mesos agent authenticate_http_readwrite flag in
> this case.  Rather than duplicating this check to multiple tests,
> set it to an appropriate default in the MesosTest fixture.
> 
> 
> Diffs
> -----
> 
>   src/tests/api_tests.cpp 86cbba4fab5e7a45298d17f3f2969391cc18be68 
>   src/tests/check_tests.cpp 2a71f41bad1a7eea2763addf5fc35d648bd46cc6 
>   src/tests/container_daemon_tests.cpp c6152571d503d7401c0f2a7099d020e3d3db26a0 
>   src/tests/containerizer/environment_secret_isolator_tests.cpp fd1cd468bd1e4c2455bb3315b085d38b2543bc6f

>   src/tests/containerizer/linux_capabilities_isolator_tests.cpp d3c456826db2c1844ebfd55acbd766d6fb7eaede

>   src/tests/containerizer/nvidia_gpu_isolator_tests.cpp 99431784dac41da531b92c9a0e3c4772a6bb57ae

>   src/tests/containerizer/ports_isolator_tests.cpp 343803028afce01874a054879f5ec39f2b85286a

>   src/tests/containerizer/posix_rlimits_isolator_tests.cpp f639cac900f8ac5d0bc2eb856e90cb4881d85ec3

>   src/tests/containerizer/volume_host_path_isolator_tests.cpp e4d0734ffdb8e9d1c7dcc2cb5aa75bbb014b6415

>   src/tests/default_executor_tests.cpp ee6dfbde02277caf330b72f6e8210924150a428c 
>   src/tests/health_check_tests.cpp bb909c5ea4a51b562ac753083fda002195ac08ad 
>   src/tests/master_slave_reconciliation_tests.cpp 1a9b40a9a269313fc6c858ab5b2a9901c5e12352

>   src/tests/master_tests.cpp e41bd942b1ab55130672f5d5b7044b376a21a7f1 
>   src/tests/mesos.cpp 103128308e64ec1e1a5f2f979a42b96fbc0cd8d6 
>   src/tests/scheduler_tests.cpp ecfce4d112464a76c14603e40c20585ec25e0ca7 
> 
> 
> Diff: https://reviews.apache.org/r/64436/diff/2/
> 
> 
> Testing
> -------
> 
> make check (Fedora 27)
> 
> 
> Thanks,
> 
> James Peach
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message