mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Mesos Reviewbot Windows <revi...@mesos.apache.org>
Subject Re: Review Request 64590: Stopped logging optional fields unconditionally in agent handler.
Date Thu, 14 Dec 2017 18:55:51 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64590/#review193827
-----------------------------------------------------------



FAIL: Mesos tests failed to build.

Reviews applied: `['64590']`

Failed command: `cmake.exe --build . --target mesos-tests --config Debug`

All the build artifacts available at: http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/64590

Relevant logs:

- [mesos-tests-build-cmake-stdout.log](http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/64590/logs/mesos-tests-build-cmake-stdout.log):

```
  D:\DCOS\mesos\mesos\src\authentication\cram_md5\authenticatee.cpp(271): warning C4267: 'argument':
conversion from 'size_t' to 'unsigned int', possible loss of data [D:\DCOS\mesos\src\mesos.vcxproj]
  D:\DCOS\mesos\mesos\src\authentication\cram_md5\authenticatee.cpp(333): warning C4267: '=':
conversion from 'size_t' to 'unsigned int', possible loss of data [D:\DCOS\mesos\src\mesos.vcxproj]
  D:\DCOS\mesos\mesos\src\authentication\cram_md5\authenticator.cpp(216): warning C4267: 'argument':
conversion from 'size_t' to 'unsigned int', possible loss of data [D:\DCOS\mesos\src\mesos.vcxproj]
  D:\DCOS\mesos\mesos\src\authentication\cram_md5\authenticator.cpp(242): warning C4267: 'argument':
conversion from 'size_t' to 'unsigned int', possible loss of data [D:\DCOS\mesos\src\mesos.vcxproj]
  D:\DCOS\mesos\mesos\src\authentication\cram_md5\authenticator.cpp(274): warning C4267: '=':
conversion from 'size_t' to 'unsigned int', possible loss of data [D:\DCOS\mesos\src\mesos.vcxproj]
  D:\DCOS\mesos\mesos\src\master/master.hpp(2093): warning C4244: 'return': conversion from
'unsigned __int64' to 'double', possible loss of data (compiling source file D:\DCOS\mesos\mesos\src\common\protobuf_utils.cpp)
[D:\DCOS\mesos\src\mesos.vcxproj]
  D:\DCOS\mesos\mesos\src\files\files.cpp(704): warning C4267: 'argument': conversion from
'size_t' to 'off_t', possible loss of data [D:\DCOS\mesos\src\mesos.vcxproj]
  D:\DCOS\mesos\mesos\src\master/master.hpp(2093): warning C4244: 'return': conversion from
'unsigned __int64' to 'double', possible loss of data (compiling source file D:\DCOS\mesos\mesos\src\master\master.cpp)
[D:\DCOS\mesos\src\mesos.vcxproj]
  D:\DCOS\mesos\mesos\src\master/master.hpp(2093): warning C4244: 'return': conversion from
'unsigned __int64' to 'double', possible loss of data (compiling source file D:\DCOS\mesos\mesos\src\master\quota_handler.cpp)
[D:\DCOS\mesos\src\mesos.vcxproj]
  D:\DCOS\mesos\mesos\src\master/master.hpp(2093): warning C4244: 'return': conversion from
'unsigned __int64' to 'double', possible loss of data (compiling source file D:\DCOS\mesos\mesos\src\master\weights_handler.cpp)
[D:\DCOS\mesos\src\mesos.vcxproj]
  D:\DCOS\mesos\mesos\src\master\master.cpp(6223): warning C4244: 'argument': conversion from
'const ::size_t' to 'double', possible loss of data [D:\DCOS\mesos\src\mesos.vcxproj]
  D:\DCOS\mesos\mesos\src\master\master.cpp(6325): warning C4244: 'argument': conversion from
'const ::size_t' to 'double', possible loss of data [D:\DCOS\mesos\src\mesos.vcxproj]
  D:\DCOS\mesos\mesos\src\master\master.cpp(6890): warning C4244: 'argument': conversion from
'const ::size_t' to 'double', possible loss of data [D:\DCOS\mesos\src\mesos.vcxproj]
  D:\DCOS\mesos\mesos\src\master\allocator\sorter\drf\sorter.cpp(589): warning C4267: 'return':
conversion from 'size_t' to 'int', possible loss of data [D:\DCOS\mesos\src\mesos.vcxproj]
  D:\DCOS\mesos\mesos\src\master\master.cpp(9014): warning C4244: 'argument': conversion from
'const ::size_t' to 'double', possible loss of data [D:\DCOS\mesos\src\mesos.vcxproj]
  D:\DCOS\mesos\mesos\src\master\master.cpp(10855): warning C4244: 'return': conversion from
'::size_t' to 'double', possible loss of data [D:\DCOS\mesos\src\mesos.vcxproj]


"D:\DCOS\mesos\src\tests\mesos-tests.vcxproj" (default target) (1) ->
"D:\DCOS\mesos\src\mesos.vcxproj" (default target) (12) ->
(ClCompile target) -> 
  D:\DCOS\mesos\mesos\src\slave\slave.cpp(7278): error C2678: binary '<<': no operator
found which takes a left-hand operand of type 'const char [16]' (or there is no acceptable
conversion) [D:\DCOS\mesos\src\mesos.vcxproj]
  D:\DCOS\mesos\mesos\src\slave\slave.cpp(7293): error C2678: binary '<<': no operator
found which takes a left-hand operand of type 'const char [16]' (or there is no acceptable
conversion) [D:\DCOS\mesos\src\mesos.vcxproj]
  D:\DCOS\mesos\mesos\src\slave\slave.cpp(7284): error C2146: syntax error: missing ';' before
identifier 'OfferOperationStatusUpdate' [D:\DCOS\mesos\src\mesos.vcxproj]

    135 Warning(s)
    3 Error(s)

Time Elapsed 00:03:05.73
```

- [mesos-tests-CMakeOutput.log](http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/64590/logs/mesos-tests-CMakeOutput.log):

```
  Creating directory "cmTC_1c679.dir\Debug\".

  Creating directory "D:\DCOS\mesos\CMakeFiles\CMakeTmp\Debug\".

  Creating directory "cmTC_1c679.dir\Debug\cmTC_1c679.tlog\".

InitializeBuildStatus:

  Creating "cmTC_1c679.dir\Debug\cmTC_1c679.tlog\unsuccessfulbuild" because "AlwaysCreate"
was specified.

ClCompile:

  C:\Program Files (x86)\Microsoft Visual Studio\2017\Community\VC\Tools\MSVC\14.12.25827\bin\HostX64\x64\CL.exe
/c /Zi /W3 /WX- /diagnostics:classic /Od /Ob0 /D WIN32 /D _WINDOWS /D COMPILER_SUPPORTS_CXX11
/D "CMAKE_INTDIR=\"Debug\"" /D _MBCS /Gm- /EHsc /RTC1 /MDd /GS /fp:precise /Zc:wchar_t /Zc:forScope
/Zc:inline /GR /Fo"cmTC_1c679.dir\Debug\" /Fd"cmTC_1c679.dir\Debug\vc141.pdb" /Gd /TP /errorReport:queue
D:\DCOS\mesos\CMakeFiles\CMakeTmp\src.cxx

  Microsoft (R) C/C++ Optimizing Compiler Version 19.12.25830.2 for x64

  Copyright (C) Microsoft Corporation.  All rights reserved.

  

  cl /c /Zi /W3 /WX- /diagnostics:classic /Od /Ob0 /D WIN32 /D _WINDOWS /D COMPILER_SUPPORTS_CXX11
/D "CMAKE_INTDIR=\"Debug\"" /D _MBCS /Gm- /EHsc /RTC1 /MDd /GS /fp:precise /Zc:wchar_t /Zc:forScope
/Zc:inline /GR /Fo"cmTC_1c679.dir\Debug\" /Fd"cmTC_1c679.dir\Debug\vc141.pdb" /Gd /TP /errorReport:queue
D:\DCOS\mesos\CMakeFiles\CMakeTmp\src.cxx

  src.cxx

  

Link:

  C:\Program Files (x86)\Microsoft Visual Studio\2017\Community\VC\Tools\MSVC\14.12.25827\bin\HostX64\x64\link.exe
/ERRORREPORT:QUEUE /OUT:"D:\DCOS\mesos\CMakeFiles\CMakeTmp\Debug\cmTC_1c679.exe" /INCREMENTAL
/NOLOGO kernel32.lib user32.lib gdi32.lib winspool.lib shell32.lib ole32.lib oleaut32.lib
uuid.lib comdlg32.lib advapi32.lib /MANIFEST /MANIFESTUAC:"level='asInvoker' uiAccess='false'"
/manifest:embed /DEBUG /PDB:"D:/DCOS/mesos/CMakeFiles/CMakeTmp/Debug/cmTC_1c679.pdb" /SUBSYSTEM:CONSOLE
/TLBID:1 /DYNAMICBASE /NXCOMPAT /IMPLIB:"D:/DCOS/mesos/CMakeFiles/CMakeTmp/Debug/cmTC_1c679.lib"
/MACHINE:X64  /machine:x64 cmTC_1c679.dir\Debug\src.obj

  cmTC_1c679.vcxproj -> D:\DCOS\mesos\CMakeFiles\CMakeTmp\Debug\cmTC_1c679.exe

FinalizeBuildStatus:

  Deleting file "cmTC_1c679.dir\Debug\cmTC_1c679.tlog\unsuccessfulbuild".

  Touching "cmTC_1c679.dir\Debug\cmTC_1c679.tlog\cmTC_1c679.lastbuildstate".

Done Building Project "D:\DCOS\mesos\CMakeFiles\CMakeTmp\cmTC_1c679.vcxproj" (default targets).



Build succeeded.

    0 Warning(s)

    0 Error(s)



Time Elapsed 00:00:00.99


Source file was:
int main() { return 0; }
```

- [mesos-tests-CMakeError.log](http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/64590/logs/mesos-tests-CMakeError.log):

```
PrepareForBuild:

  Creating directory "cmTC_c4d7c.dir\Debug\".

  Creating directory "D:\DCOS\mesos\CMakeFiles\CMakeTmp\Debug\".

  Creating directory "cmTC_c4d7c.dir\Debug\cmTC_c4d7c.tlog\".

InitializeBuildStatus:

  Creating "cmTC_c4d7c.dir\Debug\cmTC_c4d7c.tlog\unsuccessfulbuild" because "AlwaysCreate"
was specified.

ClCompile:

  C:\Program Files (x86)\Microsoft Visual Studio\2017\Community\VC\Tools\MSVC\14.12.25827\bin\HostX64\x64\CL.exe
/c /Zi /W3 /WX- /diagnostics:classic /MP /Od /Ob0 /D WIN32 /D _WINDOWS /D UNICODE /D _UNICODE
/D "CMAKE_INTDIR=\"Debug\"" /D _UNICODE /D UNICODE /Gm- /RTC1 /MTd /GS /fp:precise /Zc:wchar_t
/Zc:forScope /Zc:inline /Fo"cmTC_c4d7c.dir\Debug\" /Fd"cmTC_c4d7c.dir\Debug\vc141.pdb" /Gd
/TC /errorReport:queue D:\DCOS\mesos\CMakeFiles\CMakeTmp\CheckIncludeFile.c

  Microsoft (R) C/C++ Optimizing Compiler Version 19.12.25830.2 for x64

  Copyright (C) Microsoft Corporation.  All rights reserved.

  

  cl /c /Zi /W3 /WX- /diagnostics:classic /MP /Od /Ob0 /D WIN32 /D _WINDOWS /D UNICODE /D
_UNICODE /D "CMAKE_INTDIR=\"Debug\"" /D _UNICODE /D UNICODE /Gm- /RTC1 /MTd /GS /fp:precise
/Zc:wchar_t /Zc:forScope /Zc:inline /Fo"cmTC_c4d7c.dir\Debug\" /Fd"cmTC_c4d7c.dir\Debug\vc141.pdb"
/Gd /TC /errorReport:queue D:\DCOS\mesos\CMakeFiles\CMakeTmp\CheckIncludeFile.c

  CheckIncludeFile.c

  

D:\DCOS\mesos\CMakeFiles\CMakeTmp\CheckIncludeFile.c(1): fatal error C1083: Cannot open include
file: 'pthread.h': No such file or directory [D:\DCOS\mesos\CMakeFiles\CMakeTmp\cmTC_c4d7c.vcxproj]

Done Building Project "D:\DCOS\mesos\CMakeFiles\CMakeTmp\cmTC_c4d7c.vcxproj" (default targets)
-- FAILED.



Build FAILED.



"D:\DCOS\mesos\CMakeFiles\CMakeTmp\cmTC_c4d7c.vcxproj" (default target) (1) ->

(ClCompile target) -> 

  D:\DCOS\mesos\CMakeFiles\CMakeTmp\CheckIncludeFile.c(1): fatal error C1083: Cannot open
include file: 'pthread.h': No such file or directory [D:\DCOS\mesos\CMakeFiles\CMakeTmp\cmTC_c4d7c.vcxproj]



    0 Warning(s)

    1 Error(s)



Time Elapsed 00:00:00.57



```

- Mesos Reviewbot Windows


On Dec. 14, 2017, 6:22 p.m., Gaston Kleiman wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/64590/
> -----------------------------------------------------------
> 
> (Updated Dec. 14, 2017, 6:22 p.m.)
> 
> 
> Review request for mesos, Chun-Hung Hsiao, Greg Mann, and Jie Yu.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> The `operation_id` and `framework_id` fields are optional, so they
> should only be logged if set.
> 
> 
> Diffs
> -----
> 
>   src/slave/slave.cpp 9d0e9debf2ecd142eb6179c12ef4a0ada24b1c6c 
> 
> 
> Diff: https://reviews.apache.org/r/64590/diff/2/
> 
> 
> Testing
> -------
> 
> `make check` on GNU/Linux
> 
> 
> Thanks,
> 
> Gaston Kleiman
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message