mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Benjamin Bannier <benjamin.bann...@mesosphere.io>
Subject Re: Review Request 64299: Passed versions when launching tasks.
Date Fri, 08 Dec 2017 10:22:02 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64299/
-----------------------------------------------------------

(Updated Dec. 8, 2017, 11:22 a.m.)


Review request for mesos, Chun-Hung Hsiao, Jie Yu, and Jan Schlicht.


Changes
-------

Removed an empty line.


Bugs: MESOS-8222
    https://issues.apache.org/jira/browse/MESOS-8222


Repository: mesos


Description
-------

In this patch we inject resource versions into task launch messages
and add verification in the agent. We require that resource versions
of resource providers whose resources are used in a task have not
changed. With that we can make sure to e.g., not use resources created
in speculated operations.


Diffs (updated)
-----

  src/master/master.cpp 584398ca3a6ee62eeaa8955c72e72002f64102ad 
  src/slave/slave.hpp d9b04692c239f761037726dedfa305e77b8dfe0c 
  src/slave/slave.cpp 98370f9f4e828909ee5743e0a90932a07bd6c3c6 
  src/tests/mock_slave.hpp d986125b3ab67e0ca3d6ba264795850b3eadb3d0 
  src/tests/mock_slave.cpp 6d050ca76acee737f1996fbbd8ecdefbf1a699ee 
  src/tests/slave_tests.cpp ee490a0c9322bc1554ff2b146f75a412fad223cd 


Diff: https://reviews.apache.org/r/64299/diff/3/

Changes: https://reviews.apache.org/r/64299/diff/2-3/


Testing
-------

`make check`


Thanks,

Benjamin Bannier


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message