mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Greg Mann <g...@mesosphere.io>
Subject Re: Review Request 64096: Implemented the `OfferOperationStatusUpdateManager`.
Date Fri, 08 Dec 2017 04:44:47 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64096/#review193214
-----------------------------------------------------------



Some nits below. I can fix these while committing.


src/status_update_manager/offer_operation.hpp
Lines 17-18 (patched)
<https://reviews.apache.org/r/64096/#comment271770>

    Nit: s/__HPP/_HPP/
    
    I'll fix while committing.



src/status_update_manager/offer_operation.hpp
Lines 53 (patched)
<https://reviews.apache.org/r/64096/#comment271772>

    Nit: let's put a `that` here. Will add while committing.



src/tests/offer_operation_status_update_manager_tests.cpp
Lines 85 (patched)
<https://reviews.apache.org/r/64096/#comment271774>

    I think it's more appropriate to leave the `settle()` in the test body, so that it's clear
while viewing the tests that this is performed. I can do this while committing.



src/tests/offer_operation_status_update_manager_tests.cpp
Lines 90-93 (patched)
<https://reviews.apache.org/r/64096/#comment271775>

    Indentation.



src/tests/offer_operation_status_update_manager_tests.cpp
Lines 141 (patched)
<https://reviews.apache.org/r/64096/#comment271779>

    Why a reference?



src/tests/offer_operation_status_update_manager_tests.cpp
Lines 295 (patched)
<https://reviews.apache.org/r/64096/#comment271776>

    s/forwardeda/forwarded./


- Greg Mann


On Dec. 7, 2017, 1:22 a.m., Gaston Kleiman wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/64096/
> -----------------------------------------------------------
> 
> (Updated Dec. 7, 2017, 1:22 a.m.)
> 
> 
> Review request for mesos and Greg Mann.
> 
> 
> Bugs: MESOS-8197
>     https://issues.apache.org/jira/browse/MESOS-8197
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This class will handle the offer operation status updates generated by
> the agent and by resource providers.
> 
> 
> Diffs
> -----
> 
>   src/CMakeLists.txt 35a602d2afb3a1e6ef76a0b0df2628ce5493dc81 
>   src/Makefile.am 05e8b950a3ee13f7b2e8af9416495f2827138449 
>   src/status_update_manager/offer_operation.hpp PRE-CREATION 
>   src/status_update_manager/offer_operation.cpp PRE-CREATION 
>   src/tests/CMakeLists.txt 92db731a81303f0d1d95dfe0b80a0a512e165445 
>   src/tests/offer_operation_status_update_manager_tests.cpp PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/64096/diff/10/
> 
> 
> Testing
> -------
> 
> This patch addes new tests that passed 5000 times on GNU/Linux.
> 
> 
> Thanks,
> 
> Gaston Kleiman
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message