mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Benjamin Bannier <benjamin.bann...@mesosphere.io>
Subject Re: Review Request 64298: Added ResourceVersion to RunTask and RunTaskGroup messages.
Date Thu, 07 Dec 2017 19:04:46 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64298/
-----------------------------------------------------------

(Updated Dec. 7, 2017, 8:04 p.m.)


Review request for mesos, Chun-Hung Hsiao, Jie Yu, and Jan Schlicht.


Changes
-------

Rebased.


Bugs: MESOS-8222
    https://issues.apache.org/jira/browse/MESOS-8222


Repository: mesos


Description
-------

This commit adds the known agent resource versions to RunTaskMessage
and RunTaskGroupMessage. We also update sites where the message is
unpacked.

In a later commit we will inject versions in the master and evaluate
them in the agent.


Diffs (updated)
-----

  src/messages/messages.proto 2ab0fe8400a2de2318368d1b408b266ce647339d 
  src/slave/slave.hpp fc762fb1e8aeb57b0d7ad551d960ec4be06e8e33 
  src/slave/slave.cpp dd830d93f8a08720231e3d4a6421f7a058ba6093 
  src/tests/mock_slave.hpp d986125b3ab67e0ca3d6ba264795850b3eadb3d0 
  src/tests/mock_slave.cpp 6d050ca76acee737f1996fbbd8ecdefbf1a699ee 
  src/tests/slave_tests.cpp 25cfd4730c3d77d1886745204b13ca3cb140620c 


Diff: https://reviews.apache.org/r/64298/diff/2/

Changes: https://reviews.apache.org/r/64298/diff/1-2/


Testing
-------

`make check`


Thanks,

Benjamin Bannier


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message