mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Jie Yu <yujie....@gmail.com>
Subject Re: Review Request 64298: Added ResourceVersion to RunTask and RunTaskGroup messages.
Date Thu, 07 Dec 2017 16:53:48 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64298/#review193131
-----------------------------------------------------------


Ship it!




Ship It!

- Jie Yu


On Dec. 4, 2017, 1:12 p.m., Benjamin Bannier wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/64298/
> -----------------------------------------------------------
> 
> (Updated Dec. 4, 2017, 1:12 p.m.)
> 
> 
> Review request for mesos, Chun-Hung Hsiao, Jie Yu, and Jan Schlicht.
> 
> 
> Bugs: MESOS-8222
>     https://issues.apache.org/jira/browse/MESOS-8222
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This commit adds the known agent resource versions to RunTaskMessage
> and RunTaskGroupMessage. We also update sites where the message is
> unpacked.
> 
> In a later commit we will inject versions in the master and evaluate
> them in the agent.
> 
> 
> Diffs
> -----
> 
>   src/messages/messages.proto d7ef68f85a9f8a7702a83a3554c2dedc6d7ee339 
>   src/slave/slave.hpp 643d8559244f0842e82b293c1ef99cb26e111059 
>   src/slave/slave.cpp c07e25f668bef6b6fa3cae4b69ba90de3eb3bdcc 
>   src/tests/mock_slave.hpp d986125b3ab67e0ca3d6ba264795850b3eadb3d0 
>   src/tests/mock_slave.cpp 6d050ca76acee737f1996fbbd8ecdefbf1a699ee 
>   src/tests/slave_tests.cpp a7f6658fa467914cd74691b5631d26d85ba7c1eb 
> 
> 
> Diff: https://reviews.apache.org/r/64298/diff/1/
> 
> 
> Testing
> -------
> 
> `make check`
> 
> 
> Thanks,
> 
> Benjamin Bannier
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message