mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Chun-Hung Hsiao <chhs...@mesosphere.io>
Subject Re: Review Request 63555: Publish resource provider resources before container launch or update.
Date Wed, 06 Dec 2017 20:07:47 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63555/
-----------------------------------------------------------

(Updated Dec. 6, 2017, 8:07 p.m.)


Review request for mesos, Gilbert Song, Jie Yu, Joseph Wu, and Jan Schlicht.


Changes
-------

Added a test that uses `MockResourceProvider`.


Bugs: MESOS-7550
    https://issues.apache.org/jira/browse/MESOS-7550


Repository: mesos


Description
-------

`Slave::publishAllocatedResources()` will compute the total allocated
resources for all currently running executor containers, and takes an
`extra` argument for resources that will be used by the executor that
is about to launch, then sums them up and asks the resource provider
manager to publish the resources.


Diffs (updated)
-----

  src/resource_provider/manager.cpp 8d8b2f1396230d6edba590b8b7e9b4ca51366efe 
  src/slave/slave.hpp 643d8559244f0842e82b293c1ef99cb26e111059 
  src/slave/slave.cpp c07e25f668bef6b6fa3cae4b69ba90de3eb3bdcc 
  src/tests/mesos.hpp 3a9b1fbd4301c6cccbc770329ff71ed8ff7e86a2 
  src/tests/slave_tests.cpp a7f6658fa467914cd74691b5631d26d85ba7c1eb 


Diff: https://reviews.apache.org/r/63555/diff/2/

Changes: https://reviews.apache.org/r/63555/diff/1-2/


Testing (updated)
-------

The test is still broken. Will fix it later.


Thanks,

Chun-Hung Hsiao


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message