mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Gilbert Song <songzihao1...@gmail.com>
Subject Re: Review Request 64197: Tracked layers in memory for provisioned containers.
Date Wed, 06 Dec 2017 19:34:28 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64197/#review193032
-----------------------------------------------------------


Ship it!




Ship It!

- Gilbert Song


On Nov. 29, 2017, 10:32 p.m., Zhitao Li wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/64197/
> -----------------------------------------------------------
> 
> (Updated Nov. 29, 2017, 10:32 p.m.)
> 
> 
> Review request for mesos, Gilbert Song and Jason Lai.
> 
> 
> Bugs: MESOS-8280
>     https://issues.apache.org/jira/browse/MESOS-8280
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> While adding layer checkpointing in previous patch,
> this case was missed, thus provisioner could incorrectly
> think a container is missing layers.
> 
> 
> Diffs
> -----
> 
>   src/slave/containerizer/mesos/provisioner/provisioner.cpp 9d1a4e50fb4eb3a3888c400a1f8e3c878ac6f325

> 
> 
> Diff: https://reviews.apache.org/r/64197/diff/1/
> 
> 
> Testing
> -------
> 
> Ran a standalone mesos container, then trigger a couple `PRUNE_IMAGES` API calls through
agent API. Verified that warnings ending with `"...has no checkpointed layers"` are gone.
> 
> 
> Thanks,
> 
> Zhitao Li
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message