mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Gilbert Song <songzihao1...@gmail.com>
Subject Re: Review Request 64271: Added an unit test for docker image auto gc.
Date Wed, 06 Dec 2017 19:15:42 GMT


> On Dec. 3, 2017, 2:53 p.m., Zhitao Li wrote:
> > src/tests/containerizer/provisioner_docker_tests.cpp
> > Lines 463 (patched)
> > <https://reviews.apache.org/r/64271/diff/1/?file=1906562#file1906562line463>
> >
> >     Indicate why this needs `ROOT_` permission?

due to the chroot. all other unit tests in this file does not mention that yet.


- Gilbert


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64271/#review192657
-----------------------------------------------------------


On Dec. 1, 2017, 5:10 p.m., Gilbert Song wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/64271/
> -----------------------------------------------------------
> 
> (Updated Dec. 1, 2017, 5:10 p.m.)
> 
> 
> Review request for mesos, Jie Yu, Qian Zhang, Vinod Kone, and Zhitao Li.
> 
> 
> Bugs: MESOS-8294
>     https://issues.apache.org/jira/browse/MESOS-8294
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added an unit test for docker image auto gc.
> 
> 
> Diffs
> -----
> 
>   src/tests/containerizer/provisioner_docker_tests.cpp 832c81fe88d753b0f00dfab870d7725cf556fcef

> 
> 
> Diff: https://reviews.apache.org/r/64271/diff/1/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Gilbert Song
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message