mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Vinod Kone <vinodk...@apache.org>
Subject Re: Review Request 64383: Removed redundant `get()` call on a smart pointer.
Date Wed, 06 Dec 2017 19:04:06 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64383/#review193019
-----------------------------------------------------------


Ship it!




Ship It!

- Vinod Kone


On Dec. 6, 2017, 4:52 p.m., Benno Evers wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/64383/
> -----------------------------------------------------------
> 
> (Updated Dec. 6, 2017, 4:52 p.m.)
> 
> 
> Review request for mesos and Vinod Kone.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Registrar had the type `Owned<MockRegistry>` so this call was
> indeed redundant.
> 
> 
> Diffs
> -----
> 
>   src/tests/master_tests.cpp 0dfa8c716bc35a386dd7fa87b595360487ab8b15 
> 
> 
> Diff: https://reviews.apache.org/r/64383/diff/1/
> 
> 
> Testing
> -------
> 
> `make`
> 
> 
> Thanks,
> 
> Benno Evers
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message