mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Benno Evers <bev...@mesosphere.com>
Subject Re: Review Request 64009: Added new UpdateSlave registry operation.
Date Mon, 04 Dec 2017 16:10:37 GMT


> On Nov. 28, 2017, 12:37 a.m., Benjamin Mahler wrote:
> > src/master/registry_operations.cpp
> > Lines 64-70 (patched)
> > <https://reviews.apache.org/r/64009/diff/3/?file=1902161#file1902161line64>
> >
> >     Hm.. couldn't we normalize the info resources in the agent and master rather
than leave it in the old format? Have you thought through that?

We now moved the conversion to happen as early in the registerSlave/reregisterSlave code paths
as reasonably possible, so we now can always compare resources in `POST_RESERVATION_REFINEMENT`
format.


- Benno


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64009/#review191960
-----------------------------------------------------------


On Dec. 4, 2017, 3:28 p.m., Benno Evers wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/64009/
> -----------------------------------------------------------
> 
> (Updated Dec. 4, 2017, 3:28 p.m.)
> 
> 
> Review request for mesos, Benjamin Mahler, Michael Park, and Vinod Kone.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This operation can be used to update the stored state
> of an existing, admitted slave.
> 
> 
> Diffs
> -----
> 
>   src/master/registry_operations.hpp 5b78306fb2e2bd7e30200f112f0381a595c7b25d 
>   src/master/registry_operations.cpp 1e1eadb539482113e8ca8cb0542e5aaf34a38b41 
>   src/tests/registrar_tests.cpp 21d78e90e57c145aa9f4b26f1a2f0278390b98d4 
> 
> 
> Diff: https://reviews.apache.org/r/64009/diff/6/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Benno Evers
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message