mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Mesos Reviewbot Windows <revi...@mesos.apache.org>
Subject Re: Review Request 64291: Refactored authorization logic.
Date Mon, 04 Dec 2017 16:10:04 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64291/#review192701
-----------------------------------------------------------



Bad review!

Error:
No reviewers specified. Please find a reviewer by asking on JIRA or the mailing list.

- Mesos Reviewbot Windows


On Dec. 3, 2017, 11:27 p.m., Benjamin Hindman wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/64291/
> -----------------------------------------------------------
> 
> (Updated Dec. 3, 2017, 11:27 p.m.)
> 
> 
> Review request for mesos.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> * Introduced `ObjectApprovers` to unify authorization logic.
> * Updated code in master and agent to use `ObjectApprovers`.
> * Deleted unused code.
> 
> 
> Diffs
> -----
> 
>   src/common/http.hpp 750d3bfba1647624983108bdd23295a3b3091fe4 
>   src/common/http.cpp 3ada1f064b4bd001cd4d7dccc186641f475011a0 
>   src/common/protobuf_utils.hpp 03b7cafb264b07a5a27dbd8d5c074e96ce576ea0 
>   src/common/protobuf_utils.cpp c5504a00a7a84b824743f00c6b97ea299ac66eb4 
>   src/master/http.cpp bb040ced65495cfe78b67ca7258499c16ac5d8a1 
>   src/master/master.hpp 5d2ae658070d9c5a0bc630c15ff89dc449857f46 
>   src/master/master.cpp 883793a226849434eb833c3027d121635a86fdc4 
>   src/slave/http.hpp a51831cdcebc1998ce6d4c3c19285e598a4ec9a3 
>   src/slave/http.cpp fd0e809d5dc7722e573b66621f75d791f0911dfa 
>   src/slave/slave.cpp c07e25f668bef6b6fa3cae4b69ba90de3eb3bdcc 
> 
> 
> Diff: https://reviews.apache.org/r/64291/diff/1/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Benjamin Hindman
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message