mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Benjamin Bannier <benjamin.bann...@mesosphere.io>
Subject Review Request 64299: Passed versions when launching tasks.
Date Mon, 04 Dec 2017 13:12:29 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64299/
-----------------------------------------------------------

Review request for mesos, Chun-Hung Hsiao, Jie Yu, and Jan Schlicht.


Bugs: MESOS-8222
    https://issues.apache.org/jira/browse/MESOS-8222


Repository: mesos


Description
-------

In this patch we inject resource versions into task launch messages
and add verification in the agent. We require that resource versions
of resource providers whose resources are used in a task have not
changed. With that we can make sure to e.g., not use resources created
in speculated operations.


Diffs
-----

  src/master/master.cpp 883793a226849434eb833c3027d121635a86fdc4 
  src/slave/slave.hpp 643d8559244f0842e82b293c1ef99cb26e111059 
  src/slave/slave.cpp c07e25f668bef6b6fa3cae4b69ba90de3eb3bdcc 
  src/tests/mock_slave.hpp d986125b3ab67e0ca3d6ba264795850b3eadb3d0 
  src/tests/mock_slave.cpp 6d050ca76acee737f1996fbbd8ecdefbf1a699ee 
  src/tests/slave_tests.cpp a7f6658fa467914cd74691b5631d26d85ba7c1eb 


Diff: https://reviews.apache.org/r/64299/diff/1/


Testing
-------

`make check`


Thanks,

Benjamin Bannier


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message