mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Zhitao Li <zhitaoli...@gmail.com>
Subject Re: Review Request 64271: Added an unit test for docker image auto gc.
Date Sun, 03 Dec 2017 22:53:16 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64271/#review192657
-----------------------------------------------------------




src/tests/containerizer/provisioner_docker_tests.cpp
Lines 463 (patched)
<https://reviews.apache.org/r/64271/#comment270915>

    Indicate why this needs `ROOT_` permission?



src/tests/containerizer/provisioner_docker_tests.cpp
Lines 465 (patched)
<https://reviews.apache.org/r/64271/#comment270916>

    Why do we need a master?



src/tests/containerizer/provisioner_docker_tests.cpp
Lines 548-564 (patched)
<https://reviews.apache.org/r/64271/#comment270919>

    I guess the goal of this sleep based code block is to verify an image pruning really happened.
I don't like `sleep` in test code in general, as it slows ourselves down.
    
    A couple of alternatives:
    
    a) use a mocked containerizer so we can capture and verify that `pruneImages` are called
properly;
    b) after first container completed, and image pruning finished, empty out the `directory`
(which is used for docker registry). If we try to run the same task again, we should get an
error because the image is pruned in store cache nor available in "registrY" anymore.


- Zhitao Li


On Dec. 2, 2017, 1:10 a.m., Gilbert Song wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/64271/
> -----------------------------------------------------------
> 
> (Updated Dec. 2, 2017, 1:10 a.m.)
> 
> 
> Review request for mesos, Jie Yu, Qian Zhang, Vinod Kone, and Zhitao Li.
> 
> 
> Bugs: MESOS-8294
>     https://issues.apache.org/jira/browse/MESOS-8294
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added an unit test for docker image auto gc.
> 
> 
> Diffs
> -----
> 
>   src/tests/containerizer/provisioner_docker_tests.cpp 832c81fe88d753b0f00dfab870d7725cf556fcef

> 
> 
> Diff: https://reviews.apache.org/r/64271/diff/1/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Gilbert Song
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message