mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Jie Yu <yujie....@gmail.com>
Subject Re: Review Request 64075: Added the `ResourceProviderState` protobuf for resource providers.
Date Fri, 01 Dec 2017 23:08:57 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64075/#review192578
-----------------------------------------------------------


Fix it, then Ship it!





src/resource_provider/storage/provider.cpp
Lines 431-433 (patched)
<https://reviews.apache.org/r/64075/#comment270833>

    Let's just return Failure here



src/resource_provider/storage/provider.cpp
Lines 442 (patched)
<https://reviews.apache.org/r/64075/#comment270835>

    Please add some comments about why ignoring the NOne() case here. Might worth printing
a warning or info here.



src/resource_provider/storage/provider.cpp
Line 414 (original), 445 (patched)
<https://reviews.apache.org/r/64075/#comment270844>

    Can you handle None() case here? or at least add some comment about why it's ok to ignore
it?


- Jie Yu


On Dec. 1, 2017, 1:47 a.m., Chun-Hung Hsiao wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/64075/
> -----------------------------------------------------------
> 
> (Updated Dec. 1, 2017, 1:47 a.m.)
> 
> 
> Review request for mesos, Benjamin Bannier, Jie Yu, Joseph Wu, and Jan Schlicht.
> 
> 
> Bugs: MESOS-8265
>     https://issues.apache.org/jira/browse/MESOS-8265
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> The `ResourceProviderState` protobuf includes the list of pending offer
> operations, the total resources, and the current resource version UUID.
> Note that the pending operations do not includes completed operations
> that have not been acknowledged yet.
> 
> 
> Diffs
> -----
> 
>   src/Makefile.am 4a3b728dc2cbfaf4b10068562778a87a6b331238 
>   src/resource_provider/registry.hpp 048cd6b9327de5396c7a56637f23c08694df1b58 
>   src/resource_provider/state.hpp PRE-CREATION 
>   src/resource_provider/state.proto PRE-CREATION 
>   src/resource_provider/storage/provider.cpp f586afc256fbcb2f2bf2451ffb7e7ba1d59cfa78

> 
> 
> Diff: https://reviews.apache.org/r/64075/diff/5/
> 
> 
> Testing
> -------
> 
> make
> 
> 
> Thanks,
> 
> Chun-Hung Hsiao
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message