mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Jie Yu <yujie....@gmail.com>
Subject Re: Review Request 63731: Reconciled pending resource provider operations in agent.
Date Tue, 21 Nov 2017 23:33:58 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63731/#review191668
-----------------------------------------------------------




src/slave/slave.cpp
Lines 6753 (patched)
<https://reviews.apache.org/r/63731/#comment269509>

    s/thisResourceProvider/isForResourceProvider/
    
    `isForResourceProvider(*operation, resourceProviderId)`



src/slave/slave.cpp
Lines 6762 (patched)
<https://reviews.apache.org/r/63731/#comment269508>

    I'd do `knownOfferOperations.put(uuid, operation)`



src/slave/slave.cpp
Lines 6777-6778 (patched)
<https://reviews.apache.org/r/63731/#comment269510>

    Ditto.



src/slave/slave.cpp
Lines 6798-6799 (patched)
<https://reviews.apache.org/r/63731/#comment269511>

    We should send a `Reconcile` message to the RP so that the RP's status update manager
can send a reliable status update to the framework.



src/slave/slave.cpp
Lines 6805 (patched)
<https://reviews.apache.org/r/63731/#comment269512>

    what's `ahemt`?



src/slave/slave.cpp
Lines 6806-6808 (patched)
<https://reviews.apache.org/r/63731/#comment269520>

    DO you need to update the comments here?
    
    I guess this is the case that agent fails over and do not yet have information about those
operations from the RP.



src/slave/slave.cpp
Lines 6820 (patched)
<https://reviews.apache.org/r/63731/#comment269513>

    Can you sync with Jan on this because Jan already updated `addOfferOperation` to also
do an apply.


- Jie Yu


On Nov. 21, 2017, 9:08 p.m., Benjamin Bannier wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63731/
> -----------------------------------------------------------
> 
> (Updated Nov. 21, 2017, 9:08 p.m.)
> 
> 
> Review request for mesos, Greg Mann, Jie Yu, and Jan Schlicht.
> 
> 
> Bugs: MESOS-8207
>     https://issues.apache.org/jira/browse/MESOS-8207
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> When resource providers update their state they send a list of
> pending or unacknowledged operations to the agent. This patch add
> tracking for such operations to the agent. The agent can then forward
> these operations to the master, e.g., for calculating the unused
> resources behind an agent.
> 
> We track an operation until we either receive a updated list of
> pending or unacknowledged operations from a resource provider, or
> until we see an acknowledgement from a framework. This keeps the list
> of operations bounded and ensures that we maintain the latest
> information in the agent.
> 
> 
> Diffs
> -----
> 
>   src/slave/slave.cpp 6e9adc60f593faf1b0e56caeea04882f67af7080 
> 
> 
> Diff: https://reviews.apache.org/r/63731/diff/4/
> 
> 
> Testing
> -------
> 
> `make check`, tested as part of https://reviews.apache.org/r/63843/.
> 
> 
> Thanks,
> 
> Benjamin Bannier
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message