mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Benjamin Mahler <bmah...@apache.org>
Subject Re: Review Request 62912: Added tests for ReadWriteLock.
Date Thu, 19 Oct 2017 21:56:54 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62912/#review188769
-----------------------------------------------------------


Fix it, then Ship it!




I made some minor tweaks to the code, thanks for writing tests!


3rdparty/libprocess/src/tests/rwlock_tests.cpp
Lines 13 (patched)
<https://reviews.apache.org/r/62912/#comment265777>

    I don't think you're doing any mocking here, should just need the gtest header.


- Benjamin Mahler


On Oct. 19, 2017, 4:25 p.m., Zhitao Li wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62912/
> -----------------------------------------------------------
> 
> (Updated Oct. 19, 2017, 4:25 p.m.)
> 
> 
> Review request for mesos, Benjamin Hindman, Benjamin Mahler, Gilbert Song, and Jason
Lai.
> 
> 
> Bugs: MESOS-8075
>     https://issues.apache.org/jira/browse/MESOS-8075
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added tests for ReadWriteLock.
> 
> 
> Diffs
> -----
> 
>   3rdparty/libprocess/Makefile.am c5bfe6d62d8a93942146feb07e8423eebd70f1de 
>   3rdparty/libprocess/src/tests/CMakeLists.txt d9ca23de13100619dbb6a9c0b53f78ea30d390f1

>   3rdparty/libprocess/src/tests/rwlock_tests.cpp PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/62912/diff/3/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Zhitao Li
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message