mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Chun-Hung Hsiao <chhs...@mesosphere.io>
Subject Re: Review Request 62502: Added events to publish and unpublish resources.
Date Wed, 18 Oct 2017 02:54:48 GMT


> On Sept. 22, 2017, 7:05 p.m., Chun-Hung Hsiao wrote:
> > include/mesos/resource_provider/resource_provider.proto
> > Lines 56 (patched)
> > <https://reviews.apache.org/r/62502/diff/1/?file=1832832#file1832832line56>
> >
> >     Can you elaborate the needs of `uuid` and `framework_id`?

We need the `uuid` for ack, and `framework_id` for ERP to checkpoint the allocation because
of the current allocation interface (https://github.com/apache/mesos/blob/master/include/mesos/allocator/allocator.hpp#L342).
But, we can consider changing the interface and remove `framework_id` here to keep an RP unaware
of frameworks. Thoughts?


- Chun-Hung


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62502/#review186007
-----------------------------------------------------------


On Oct. 13, 2017, 12:01 p.m., Jan Schlicht wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62502/
> -----------------------------------------------------------
> 
> (Updated Oct. 13, 2017, 12:01 p.m.)
> 
> 
> Review request for mesos, Benjamin Bannier, Chun-Hung Hsiao, and Jie Yu.
> 
> 
> Bugs: MESOS-8089
>     https://issues.apache.org/jira/browse/MESOS-8089
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Before launching a task that use resource provider resources, the Mesos
> master will instruct the resource provider to make these resources
> available for the task. External resource providers will checkpoint
> informations to be able to reconcile resource usage in case of a
> failover. Resource providers will acknowledge the 'PUBLISH'/'UNPUBLISH'
> operations by sending back 'PUBLISHED'/'UNPUBLISHED' together with
> the UUID of the operation.
> 
> 
> Diffs
> -----
> 
>   include/mesos/resource_provider/resource_provider.proto f5a9073075327019fd133bd51265f695ef464845

>   include/mesos/v1/resource_provider/resource_provider.proto e5cbede5b6e57a8641fca1ebfee5454f292cc24c

>   src/resource_provider/manager.cpp 31fcb789f5ab907511e868c374c49f7457a33ed3 
>   src/resource_provider/storage/provider.cpp 46224997430ac0c568904d80014166a6f059907f

>   src/resource_provider/validation.cpp d2927227f60ab0d4ae2481ad73a31ee444b48ee0 
>   src/tests/mesos.hpp 24d220e292bc1e137992e8f81484477b62bd0896 
> 
> 
> Diff: https://reviews.apache.org/r/62502/diff/2/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Jan Schlicht
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message