mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Zhitao Li <zhitaoli...@gmail.com>
Subject Re: Review Request 62911: Added a RWMutex to libprocess.
Date Tue, 17 Oct 2017 19:55:41 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62911/
-----------------------------------------------------------

(Updated Oct. 17, 2017, 7:55 p.m.)


Review request for mesos, Benjamin Hindman, Benjamin Mahler, Gilbert Song, and Jason Lai.


Changes
-------

Add new header to Makefile.am


Bugs: MESOS-8075
    https://issues.apache.org/jira/browse/MESOS-8075


Repository: mesos


Description
-------

The `RWMutex` class is similar to `Mutex`, but allows extra concurrency if
some actions can be performed concurrently safely while certain actions
require full mutual exclusive.

This implementation guarantees starvation free for `lock()` by queuing up
`rlock()` when some `lock()` is already in queue.


Diffs (updated)
-----

  3rdparty/CMakeLists.txt a37a8c60bc41b4bef95c79d4503e1bbe62551750 
  3rdparty/libprocess/Makefile.am c5bfe6d62d8a93942146feb07e8423eebd70f1de 
  3rdparty/libprocess/include/Makefile.am 94c7a722aab6c36174f117f0b6239cb988e476a9 
  3rdparty/libprocess/include/process/gtest.hpp f0ffd9a117c7ce42cf363b381ea2155efca3cec7 
  3rdparty/libprocess/include/process/protobuf.hpp fe152f273332470ac50f9715291897bb04cf95b9

  3rdparty/libprocess/include/process/rwmutex.hpp PRE-CREATION 
  3rdparty/libprocess/include/process/ssl/utilities.hpp b7cc31c33fd35c93754407f8b350eeb993177f1d

  3rdparty/libprocess/src/libevent_ssl_socket.hpp 640fa676ef570f7fcf3f96249662837497a2c76c

  3rdparty/libprocess/src/libevent_ssl_socket.cpp 1c95ebabfefd07aaeb053b965ab8e4550dfccaef

  3rdparty/libprocess/src/openssl.hpp 0c4192f9087c8fabfd7832d2be86ccc05af777ec 
  3rdparty/libprocess/src/openssl.cpp f2fe90bfdf87dbc674b231f6392e95a95ebd9736 
  3rdparty/libprocess/src/ssl/utilities.cpp 9b1d6229c3aa7d7045d492d377223d56bca16156 
  3rdparty/libprocess/src/tests/benchmarks.cpp e6c77d565d5acf72b475a085e9504679253b4b97 
  3rdparty/libprocess/src/tests/benchmarks.proto 5a29f3b4e929d6a50030fb2f43ecf10ec9f2c519

  3rdparty/libprocess/src/tests/http_tests.cpp 0f4046fa82bda0f59dbef46eb51386af060bc933 
  3rdparty/stout/include/stout/os/open.hpp 1443b63d260b3da38073f234d15ffb4b97d4a736 
  3rdparty/stout/include/stout/os/windows/fcntl.hpp 5800ec92f85401a80cb813afd880be2e5a24a3af

  3rdparty/stout/include/stout/os/windows/fd.hpp d7f8cdf1ad877eb55589bf5a9e75d295f91990a7

  3rdparty/stout/include/stout/windows.hpp 7aa0ba72c4cc3b688ce6374b3308945ea8cb7572 
  CHANGELOG 87d005e7ee9efbfce26262f23e7a1525bc7ff949 
  cmake/CompilationConfigure.cmake 929e45bd810c99e036d433a8f0a0bc978c9841a2 
  docs/agent-recovery.md 35cd5b1a38a099d87ab337df116b7356fcaa7c36 
  docs/authorization.md fdbef770c38ab38ab748b4f943b331d4442a2ce1 
  docs/cmake-examples.md fe2cfab94ff448fcf77913abcd0c5509a176b63c 
  docs/cmake.md 1e1a27ef67d256eb892a5eb455928c2424bb3fed 
  docs/configuration-cmake.md PRE-CREATION 
  docs/configuration.md 6c593ffa3413f62fa58327fbe0f14ccea78ddfec 
  docs/configuration/agent.md 5c1b469f28d4a7af0aebad5da65a00dd0e6c2a6c 
  docs/configuration/autotools.md c6ac196fd5023391143313821185cac096b41a2b 
  docs/configuration/cmake.md 68757d30400da06935b17650727f4e2b92a3997c 
  docs/configuration/libprocess.md 25a547e6ebf62dfb4c437521e2a761c455652c01 
  docs/configuration/master-and-agent.md 53bcead6dcf66eaa04c744817bab9f24418b3d72 
  docs/configuration/master.md 6af16a08257680963884d07a325803487f677c37 
  docs/container-image.md 99f4f5c5b617f5deb618614fda1365d72c8685de 
  docs/containerizer-internals.md 63bc8e6f181ff67b05f07f7131cb66545788e68a 
  docs/docker-containerizer.md 941a1536b4213bb8b36f359f24b440a025b9b52e 
  docs/fetcher.md 882988b653c32e985f3bc249943721608d5bae6e 
  docs/getting-started.md da1471e6149d2f7b7313416ade0cd5b20daf8ba7 
  docs/home.md 6a6bd736367505e00c27e5ecd37a68c8e01efe10 
  docs/isolators/cgroups-blkio.md 81706b4ea8ab64736a6ba3849b3794cfae853b6b 
  docs/isolators/cgroups-cpu.md ce29a890ee01f01eb01b2fe1f64c8b4ad83b4be7 
  docs/isolators/namespaces-pid.md 83867aeb2332d8274136e11666a5c7f798755cb2 
  docs/logging.md 28039141fecf9d84baa9d5f419c33419647de5c8 
  docs/mesos-containerizer.md 9cb071273a5ce42784457ea01b363911fdb7773d 
  docs/powered-by-mesos.md 4eb3a8de30d9bd0b4163da6df152c94240a5c0df 
  docs/quota.md 9d1a9d2abbdd261aed5707c41ac09fc9e29ff9ab 
  docs/sandbox.md 3b44112b9b1de7fcb31a9bd3f56289b4ed9e9f13 
  docs/upgrades.md 6370c06a497161317884f61f376308423b744fe1 
  include/mesos/agent/agent.proto 4df3dcef4bd1d42cb8b4955e290bd38038355e46 
  include/mesos/authentication/authentication.proto 411bfd18a722c96ba647ea3b614eefa73e221271

  include/mesos/master/master.proto 87083beec66a9f57803bfb0735188fcdedafaa87 
  include/mesos/mesos.proto 859fdff4d9a0604bc506b08af79075084ae23466 
  include/mesos/scheduler/scheduler.proto f82f74d1c3767f97a1e6dad8acf4602f39e18380 
  include/mesos/slave/containerizer.proto 689acfcbbb07f071b6195472118a7a7520a44abd 
  include/mesos/v1/agent/agent.proto e99d23d55a0951f2ed728360e103d83ea5a1ad7f 
  include/mesos/v1/mesos.proto cfd4abd3af1d8c9fbd31659161eada9ec9f92282 
  src/cli/execute.cpp f5d4bc5da26f232a1fad1169b0c656b19132b853 
  src/common/protobuf_utils.hpp c43ab75b5492320dfe19a7c723a72ac52b8ab722 
  src/common/protobuf_utils.cpp fd4858a64dfc136dd03cb1eef4c97d0f8d43bdae 
  src/launcher/default_executor.cpp e58766fed88ff949f2ff268433c3857f68bcc13a 
  src/master/allocator/mesos/hierarchical.cpp 445307411bc1df4b1468df0d8fb02181bc4287ed 
  src/messages/log.proto 88a489ca12a36075076830a14bdad1038e4ba2cc 
  src/messages/messages.proto 0a32b3457e9143a7d48670610ca3e56dd516136f 
  src/slave/containerizer/mesos/containerizer.hpp 6d356ccf82f36df8c6f558fb0ace7d9f982a3d6b

  src/slave/containerizer/mesos/containerizer.cpp 78fdd21f8b7ede4beedff31ba2b488ffebd4ea31

  src/slave/containerizer/mesos/isolators/network/port_mapping.cpp 55672b14b44005673214aa49aa5ea7be8e7bffb8

  src/slave/http.cpp f2e06aff95e0628624b6ed25de222fd3f3577a0b 
  src/slave/posix_signalhandler.hpp 9867bdfc3c7f8494af01443d1460a722c4a5db2e 
  src/slave/slave.cpp 4d7dc8e9a3901b00103031e24e5d6328d0f2e2ad 
  src/slave/windows_ctrlhandler.hpp cd73d68e89a1f0176bfbfbf8f1614dacd461e70c 
  src/tests/api_tests.cpp 0e99e7bf3a2cf4243cd73a5cb857bfc4d4e55f78 
  src/tests/containerizer/cni_isolator_tests.cpp e673d914fa9251fa585deea3a29438371c185fdb

  src/tests/containerizer/io_switchboard_tests.cpp c3410cdbb21b974455d443a18e4af09eddea59ca

  src/tests/default_executor_tests.cpp 68312010a45df5dbdb6d9d4c49d1faa5d8c60472 
  src/tests/dynamic_weights_tests.cpp 5cc86914c8433c27becc11f3bb02eee293ab4222 
  src/tests/hierarchical_allocator_tests.cpp 48b48ad70f44cc2232c2a29699267027f9937b8a 
  src/tests/master_allocator_tests.cpp 3400d70bb0ba564eac43c4639eee0efd4d8059e6 
  src/tests/master_authorization_tests.cpp eff97f155e7472a0cd5994408ed73474392593ad 
  src/tests/master_quota_tests.cpp 058f6d24da50cbf3c28b091afa88f634a8102b62 
  src/tests/master_tests.cpp 5d96457c86871b27c2fbe7f41a9444bbc2da6e06 
  src/tests/persistent_volume_endpoints_tests.cpp 444737a6c1d251e23971d9a4501f3ef76fcf5ed5

  src/tests/persistent_volume_tests.cpp 11fe43255cd8121f94c93a0437f7499fee1b6514 
  src/tests/registrar_tests.cpp 210b2286f3264574516913c716eca8fc6d70a442 
  src/tests/reservation_endpoints_tests.cpp e70dd0dd36def4fbb5b61519f8bb949c50afe36e 
  src/tests/resource_provider_manager_tests.cpp ca49e1f0203494fc8b4a4507c33e5a3885a14a59 
  src/tests/role_tests.cpp 568ea90427cfb870b77a3c1809d8be1715d2ca33 
  src/tests/slave_authorization_tests.cpp 868e39ebac3b56374463b6b8278e93a49a2dc8cd 
  src/tests/slave_tests.cpp 91d97d195acd695ae9c469651596511eafb50557 
  support/apply-reviews.py 0ef28cb02bc65acfeb7ea6808f74e1620a8a85c4 
  support/mesos-tidy/Dockerfile 61455ebdf75ffd995ad6ce8fc96c547b52cb7d84 
  support/mesos-tidy/entrypoint.sh adb554f24ae4ae5f3959c93669b44e40ccb3c77c 
  support/push-commits.py 3e9d05cb03443e5a46422da67e91d43a119a66c6 


Diff: https://reviews.apache.org/r/62911/diff/2/

Changes: https://reviews.apache.org/r/62911/diff/1-2/


Testing
-------


Thanks,

Zhitao Li


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message