mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Mesos Reviewbot <revi...@mesos.apache.org>
Subject Re: Review Request 62891: Increased level of verbose logs for libprocess actor state transitions.
Date Tue, 17 Oct 2017 14:57:35 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62891/#review188315
-----------------------------------------------------------



Patch looks great!

Reviews applied: [62891]

Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose
--disable-libtool-wrappers' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh

- Mesos Reviewbot


On Oct. 11, 2017, 1:57 p.m., Armand Grillet wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62891/
> -----------------------------------------------------------
> 
> (Updated Oct. 11, 2017, 1:57 p.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov, Benjamin Mahler, and Till Toenshoff.
> 
> 
> Bugs: MESOS-8074
>     https://issues.apache.org/jira/browse/MESOS-8074
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Increases vlog level of some recurring events to improve readability.
> Specifically, we now log the following events on vlog level three
> instead of level two:
>   "Spawned process <process>",
>   "Resuming <process>",
>   "Cleaning up <process>",
>   "Donating thread to <process> while waiting".
> 
> This does not imply a general change or a holistic approach concerning
> the libprocess verbose logs.
> 
> 
> Diffs
> -----
> 
>   3rdparty/libprocess/src/process.cpp a81ef747957db5bf388fac1a853c12fdd60d0cf7 
> 
> 
> Diff: https://reviews.apache.org/r/62891/diff/3/
> 
> 
> Testing
> -------
> 
> Run `GLOG_v=2 ./mesos-local.sh --log_dir=/tmp/test-mesos/log/ --num_slaves=3 --port=5037
--work_dir=/tmp/test-mesos/work/` and `GLOG_v=3 ./mesos-local.sh --log_dir=/tmp/test-mesos/log/
--num_slaves=3 --port=5037 --work_dir=/tmp/test-mesos/work/` and checked that the new output
was as expected.
> 
> 
> Thanks,
> 
> Armand Grillet
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message