mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Mesos Reviewbot <revi...@mesos.apache.org>
Subject Re: Review Request 62903: Added the `UPDATE_TOTAL_RESOURCES` call.
Date Mon, 16 Oct 2017 07:19:00 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62903/#review188107
-----------------------------------------------------------



Bad patch!

Reviews applied: [62903, 62502, 61947, 61946, 61810, 58021, 58047, 58048, 62282]

Failed command: python support/apply-reviews.py -n -r 61947

Error:
2017-10-16 07:18:59 URL:https://reviews.apache.org/r/61947/diff/raw/ [8417/8417] -> "61947.patch"
[1]
error: patch failed: src/tests/resource_provider_manager_tests.cpp:339
error: src/tests/resource_provider_manager_tests.cpp: patch does not apply

Full log: https://builds.apache.org/job/Mesos-Reviewbot/19801/console

- Mesos Reviewbot


On Oct. 16, 2017, 6:16 a.m., Chun-Hung Hsiao wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62903/
> -----------------------------------------------------------
> 
> (Updated Oct. 16, 2017, 6:16 a.m.)
> 
> 
> Review request for mesos, Benjamin Bannier, Jie Yu, and Jan Schlicht.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Now a resource provider can first `SUBSCRIBE` to the resource provider
> manager without resources to get its ID, then use the ID to locate the
> checkpoints for recovery and prepare persistent work directory, and then
> update its total resources later through `UPDATE_TOTAL_RESOURCE`.
> 
> This patch also renames `UPDATE` to `UPDATE_OPERATION_STATUS`.
> 
> 
> Diffs
> -----
> 
>   include/mesos/resource_provider/resource_provider.proto f5a9073075327019fd133bd51265f695ef464845

>   include/mesos/v1/resource_provider/resource_provider.proto e5cbede5b6e57a8641fca1ebfee5454f292cc24c

>   src/resource_provider/manager.cpp 31fcb789f5ab907511e868c374c49f7457a33ed3 
>   src/resource_provider/validation.cpp d2927227f60ab0d4ae2481ad73a31ee444b48ee0 
>   src/tests/resource_provider_manager_tests.cpp c29b89207b0ec24ee287a3a3034f5d1e7cefa3ff

>   src/tests/resource_provider_validation_tests.cpp f182bff4670318e9de22c2915c5dbb423a74ad6c

> 
> 
> Diff: https://reviews.apache.org/r/62903/diff/4/
> 
> 
> Testing
> -------
> 
> make tests
> 
> 
> Thanks,
> 
> Chun-Hung Hsiao
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message