mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Qian Zhang <zhq527...@gmail.com>
Subject Re: Review Request 62836: Ignored the tasks already being killed when killing the task group.
Date Thu, 12 Oct 2017 12:57:33 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62836/
-----------------------------------------------------------

(Updated Oct. 12, 2017, 8:57 p.m.)


Review request for mesos and Vinod Kone.


Changes
-------

Addressed Vinod's comments.


Bugs: MESOS-8051
    https://issues.apache.org/jira/browse/MESOS-8051


Repository: mesos


Description
-------

When the scheduler tries to kill multiple tasks in the task group
simultaneously, the default executor will kill the tasks one by
one. When the first task is killed, the default executor will kill
all the other tasks in the task group, however, we need to ignore
the tasks which are already being killed, otherwise, the check
`CHECK(!container->killing);` in `DefaultExecutor::kill()` will fail.


Diffs (updated)
-----

  src/launcher/default_executor.cpp 136c000917b2c4fdaf68fd460764c3a15fdf3bf0 


Diff: https://reviews.apache.org/r/62836/diff/2/

Changes: https://reviews.apache.org/r/62836/diff/1-2/


Testing
-------


Thanks,

Qian Zhang


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message