mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Benjamin Bannier <bbann...@apache.org>
Subject Re: Review Request 62903: Added the `UPDATE_TOTAL_RESOURCES` call.
Date Thu, 12 Oct 2017 12:14:04 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62903/#review187775
-----------------------------------------------------------



Could you also adjust the tests? Currently they do not compile.


src/resource_provider/manager.cpp
Lines 42 (patched)
<https://reviews.apache.org/r/62903/#comment264821>

    We need to include the header of the header associated to this implementation file first,
https://google.github.io/styleguide/cppguide.html#Names_and_Order_of_Includes.


- Benjamin Bannier


On Oct. 11, 2017, 9:13 p.m., Chun-Hung Hsiao wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62903/
> -----------------------------------------------------------
> 
> (Updated Oct. 11, 2017, 9:13 p.m.)
> 
> 
> Review request for mesos, Benjamin Bannier, Jie Yu, and Jan Schlicht.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Now a resource provider can first `SUBSCRIBE` to the resource provider
> manager without resources to get its ID, then use the ID to locate the
> checkpoints for recovery and prepare persistent work directory, and then
> update its total resources later through `UPDATE_TOTAL_RESOURCE`.
> 
> This patch also renames `UPDATE` to `UPDATE_OPERATION_STATUS`.
> 
> 
> Diffs
> -----
> 
>   include/mesos/resource_provider/resource_provider.proto f5a9073075327019fd133bd51265f695ef464845

>   include/mesos/v1/resource_provider/resource_provider.proto e5cbede5b6e57a8641fca1ebfee5454f292cc24c

>   src/resource_provider/manager.cpp 31fcb789f5ab907511e868c374c49f7457a33ed3 
>   src/resource_provider/validation.cpp d2927227f60ab0d4ae2481ad73a31ee444b48ee0 
> 
> 
> Diff: https://reviews.apache.org/r/62903/diff/2/
> 
> 
> Testing
> -------
> 
> make tests
> 
> 
> Thanks,
> 
> Chun-Hung Hsiao
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message