mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Qian Zhang <zhq527...@gmail.com>
Subject Re: Review Request 62836: Ignored the tasks already being killed when killing the task group.
Date Thu, 12 Oct 2017 09:09:41 GMT


> On Oct. 12, 2017, 4:10 p.m., Benjamin Bannier wrote:
> > Does it makes sense to add a test for this?

Yeah, I added a test here: https://reviews.apache.org/r/62837/


- Qian


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62836/#review187752
-----------------------------------------------------------


On Oct. 9, 2017, 9:03 a.m., Qian Zhang wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62836/
> -----------------------------------------------------------
> 
> (Updated Oct. 9, 2017, 9:03 a.m.)
> 
> 
> Review request for mesos and Vinod Kone.
> 
> 
> Bugs: MESOS-8051
>     https://issues.apache.org/jira/browse/MESOS-8051
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> When the scheduler tries to kill multiple tasks in the task group
> simultaneously, the default executor will kill the tasks one by
> one. When the first task is killed, the default executor will kill
> all the other tasks in the task group, however, we need to ignore
> the tasks which are already being killed, otherwise, the check
> `CHECK(!container->killing);` in `DefaultExecutor::kill()` will fail.
> 
> 
> Diffs
> -----
> 
>   src/launcher/default_executor.cpp 136c000917b2c4fdaf68fd460764c3a15fdf3bf0 
> 
> 
> Diff: https://reviews.apache.org/r/62836/diff/1/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Qian Zhang
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message