mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Jan Schlicht <...@mesosphere.io>
Subject Re: Review Request 62502: Added PUBLISH and UNPUBLISH events.
Date Thu, 12 Oct 2017 08:18:25 GMT


> On Oct. 12, 2017, 1:37 a.m., Chun-Hung Hsiao wrote:
> > include/mesos/resource_provider/resource_provider.proto
> > Lines 65 (patched)
> > <https://reviews.apache.org/r/62502/diff/1/?file=1832832#file1832832line65>
> >
> >     Is this `uuid` for RP to acknowledge this `Publish` event? Then should we add
the corresponding ack calls as well? Ditto below for `Unpublish`.

Yes, exactly that! I wanted to add the ACK calls in a later review, but I agree that's it's
better to put them in this one as this will give more context. Will update this patch accordingly.


- Jan


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62502/#review187703
-----------------------------------------------------------


On Sept. 22, 2017, 1:26 p.m., Jan Schlicht wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62502/
> -----------------------------------------------------------
> 
> (Updated Sept. 22, 2017, 1:26 p.m.)
> 
> 
> Review request for mesos, Benjamin Bannier, Chun-Hung Hsiao, and Jie Yu.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Before launching a task that use resource provider resources, the Mesos
> master will instruct the resource provider to make these resources
> available for the task. Also the resource provider will checkpoint
> informations to be able to reconcile resource usage in case of a
> failover.
> 
> 
> Diffs
> -----
> 
>   include/mesos/resource_provider/resource_provider.proto f5a9073075327019fd133bd51265f695ef464845

>   include/mesos/v1/resource_provider/resource_provider.proto e5cbede5b6e57a8641fca1ebfee5454f292cc24c

>   src/resource_provider/storage/provider.cpp 46224997430ac0c568904d80014166a6f059907f

>   src/tests/mesos.hpp b0749db273c91692b91d7ca87f975694b18e422c 
> 
> 
> Diff: https://reviews.apache.org/r/62502/diff/1/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Jan Schlicht
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message