mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Mesos Reviewbot Windows <revi...@mesos.apache.org>
Subject Re: Review Request 62901: Used protobuf arenas for creating messages in ProtobufProcess.
Date Thu, 12 Oct 2017 02:03:06 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62901/#review187727
-----------------------------------------------------------



FAIL: Failed to apply the dependent review: 62898.

Failed command: `python.exe .\support\apply-reviews.py -n -r 62898`

All the build artifacts available at: http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/62901

Relevant logs:

- [apply-review-62898-stdout.log](http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/62901/logs/apply-review-62898-stdout.log):

```
error: patch failed: 3rdparty/libprocess/include/process/protobuf.hpp:128
error: 3rdparty/libprocess/include/process/protobuf.hpp: patch does not apply
```

- Mesos Reviewbot Windows


On Oct. 11, 2017, 10:35 a.m., Dmitry Zhuk wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62901/
> -----------------------------------------------------------
> 
> (Updated Oct. 11, 2017, 10:35 a.m.)
> 
> 
> Review request for mesos and Benjamin Mahler.
> 
> 
> Bugs: MESOS-6971
>     https://issues.apache.org/jira/browse/MESOS-6971
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This changes `ProtobufProcess` to use arenas for creating messages.
> 
> 
> Diffs
> -----
> 
>   3rdparty/libprocess/include/process/protobuf.hpp 2b6b623e04c6d629647287e4bdf617a6f9e8d813

> 
> 
> Diff: https://reviews.apache.org/r/62901/diff/1/
> 
> 
> Testing
> -------
> 
> Ran benchmark
> ```
> ./benchmarks --gtest_filter=ProcessTest.Process_BENCHMARK_MessagePassing
> ```
> before and after changes with the following results:
> ```
> Without arenas
> [ RUN      ] ProcessTest.Process_BENCHMARK_MessagePassing
> Size: 4,	elapsed: 12.638082ms
> Size: 28,	elapsed: 38.13611ms
> Size: 124,	elapsed: 136.028145ms
> Size: 508,	elapsed: 514.481138ms
> Size: 2048,	elapsed: 2.009934749secs
> Size: 8208,	elapsed: 8.027707078secs
> Size: 32848,	elapsed: 32.188444623secs
> [       OK ] ProcessTest.Process_BENCHMARK_MessagePassing (42936 ms)
> 
> [ RUN      ] ProcessTest.Process_BENCHMARK_MessagePassing
> Size: 4,	elapsed: 13.574658ms
> Size: 28,	elapsed: 38.735425ms
> Size: 124,	elapsed: 135.356633ms
> Size: 508,	elapsed: 513.202006ms
> Size: 2048,	elapsed: 2.016349277secs
> Size: 8208,	elapsed: 8.148115463secs
> Size: 32848,	elapsed: 32.266659276secs
> [       OK ] ProcessTest.Process_BENCHMARK_MessagePassing (43139 ms)
> 
> 
> With arenas
> [ RUN      ] ProcessTest.Process_BENCHMARK_MessagePassing
> Size: 4,	elapsed: 17.66253ms
> Size: 28,	elapsed: 42.242613ms
> Size: 124,	elapsed: 133.215018ms
> Size: 508,	elapsed: 478.285954ms
> Size: 2048,	elapsed: 1.846806816secs
> Size: 8208,	elapsed: 7.807271474secs
> Size: 32848,	elapsed: 32.344994264secs
> [       OK ] ProcessTest.Process_BENCHMARK_MessagePassing (42678 ms)
> [----------] 1 test from ProcessTest (42678 ms total)
> 
> 
> [ RUN      ] ProcessTest.Process_BENCHMARK_MessagePassing
> Size: 4,	elapsed: 17.651803ms
> Size: 28,	elapsed: 42.907844ms
> Size: 124,	elapsed: 134.527995ms
> Size: 508,	elapsed: 479.715174ms
> Size: 2048,	elapsed: 1.839642098secs
> Size: 8208,	elapsed: 7.847239368secs
> Size: 32848,	elapsed: 32.519693203secs
> [       OK ] ProcessTest.Process_BENCHMARK_MessagePassing (42888 ms)
> [----------] 1 test from ProcessTest (42888 ms total)
> 
> ```
> 
> 
> Thanks,
> 
> Dmitry Zhuk
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message