mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Till Toenshoff <toensh...@me.com>
Subject Re: Review Request 62886: Increased level for recurring allocator verbose logs.
Date Wed, 11 Oct 2017 16:31:18 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62886/#review187663
-----------------------------------------------------------



Let's also make the commit description a bit more like the next one in that chain, please.


src/master/allocator/mesos/hierarchical.cpp
Line 1466 (original), 1466 (patched)
<https://reviews.apache.org/r/62886/#comment264713>

    Why not this one to `VLOG(2)`?


- Till Toenshoff


On Oct. 11, 2017, 1:29 p.m., Armand Grillet wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62886/
> -----------------------------------------------------------
> 
> (Updated Oct. 11, 2017, 1:29 p.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov, Benjamin Mahler, and Till Toenshoff.
> 
> 
> Bugs: MESOS-8072
>     https://issues.apache.org/jira/browse/MESOS-8072
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> To reduce noisiness, recurring events "Performed allocation for
> <candidate>", "No allocations performed" and "No inverse offers
> to send out!" are now visible at level 2 instead of 1.
> 
> 
> Diffs
> -----
> 
>   src/master/allocator/mesos/hierarchical.cpp 22131309a38fc6cbb0a68455f94ef6075076d4e7

> 
> 
> Diff: https://reviews.apache.org/r/62886/diff/1/
> 
> 
> Testing
> -------
> 
> Run `GLOG_v=1 ./mesos-local.sh --log_dir=/tmp/test-mesos/log/ --num_slaves=3 --port=5037
--work_dir=/tmp/test-mesos/work/` and `GLOG_v=2 ./mesos-local.sh --log_dir=/tmp/test-mesos/log/
--num_slaves=3 --port=5037 --work_dir=/tmp/test-mesos/work/` and checked that the new output
was correct.
> 
> 
> Thanks,
> 
> Armand Grillet
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message