mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Kevin Klues <klue...@gmail.com>
Subject Re: Review Request 62799: Fixed an issue for the I/O switchboard process lifetime.
Date Tue, 10 Oct 2017 12:21:50 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62799/#review187519
-----------------------------------------------------------




src/slave/containerizer/mesos/io/switchboard.cpp
Lines 560 (patched)
<https://reviews.apache.org/r/62799/#comment264530>

    So if we don't put it in this slice, then it will die along with the agent if it crashes
(or is restarted manually)?
    
    I thought that it would just be reparented to the init process but continue running (even
without this change).


- Kevin Klues


On Oct. 6, 2017, 4:32 a.m., Jie Yu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62799/
> -----------------------------------------------------------
> 
> (Updated Oct. 6, 2017, 4:32 a.m.)
> 
> 
> Review request for mesos, Joseph Wu and Kevin Klues.
> 
> 
> Bugs: MESOS-8056
>     https://issues.apache.org/jira/browse/MESOS-8056
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> We expect the I/O switchboard process to last across agent restarts
> (similar to log rotate process or executor processes). Therefore, we
> should put it into 'mesos_executor.slice' like others.
> 
> 
> Diffs
> -----
> 
>   src/slave/containerizer/mesos/io/switchboard.cpp 63d3cf80d8af6347c70fa6b7e2fd824faa0c7e3f

> 
> 
> Diff: https://reviews.apache.org/r/62799/diff/1/
> 
> 
> Testing
> -------
> 
> sudo make check
> 
> 
> Thanks,
> 
> Jie Yu
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message