mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Benjamin Bannier <bbann...@apache.org>
Subject Review Request 62834: Applied checkpointing to dynamic agent total resources.
Date Mon, 09 Oct 2017 12:14:18 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62834/
-----------------------------------------------------------

Review request for mesos, Jie Yu and Jan Schlicht.


Bugs: MESOS-8058
    https://issues.apache.org/jira/browse/MESOS-8058


Repository: mesos


Description
-------

Previously agents only had static total resources stored as part of
their 'SlaveInfo'. Any operations were always applied to these
resources. We have since changed 'UpdateSlaveMessage' to be able to
communicate changes to agent total resources, and now trigger such an
update on e.g., agent registration. While the transmitted information
was redundant for now, this still introduced a race between agents
informing the master about their resources with an
'UpdateSlaveMessage' and the master attempting to update agents with
'CheckpointResourcesMessage'.

This patch applies checkpointed resources to the potentially dynamic
agent total resources instead of its static resources. This allows us
to catch inconsistencies between the master's view of the agent and
the agent's actual state in the agent and potentially trigger a
reconciliation.


Diffs
-----

  src/slave/slave.cpp 2e05637ed10a39eb3f4ce953506b1cb5d50caf3c 


Diff: https://reviews.apache.org/r/62834/diff/1/


Testing
-------

`make check`


Thanks,

Benjamin Bannier


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message