mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Benjamin Bannier <bbann...@apache.org>
Subject Review Request 62843: Allowed 'applyCheckpointedResources' to work on modified resources.
Date Mon, 09 Oct 2017 12:14:14 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62843/
-----------------------------------------------------------

Review request for mesos, Jie Yu and Jan Schlicht.


Bugs: MESOS-8058
    https://issues.apache.org/jira/browse/MESOS-8058


Repository: mesos


Description
-------

The function 'applyCheckpointedResources' assumed that the resources
to modify had no previous operations applied to them, but already
implemented the functionality to "undo" operations on resources in
order to identify the resource an operation is applied on.

This change extracts this functionality into a separate function, and
now undos operations on the source resources as well. This allows
callers to pass resources which had operations applied to them to
'applyCheckpointedResources'. Currently all source resources are still
plain in that no operations had been applied to them. We will change
calling code in a later patch.


Diffs
-----

  src/common/resources_utils.hpp 18e3d9d4baad23669d00542594f5c15a989b7b9e 
  src/common/resources_utils.cpp e34cd8a3c9046a6f12c12a275a7b3a852b492f4c 


Diff: https://reviews.apache.org/r/62843/diff/1/


Testing
-------

`make check`


Thanks,

Benjamin Bannier


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message