mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Mesos Reviewbot <revi...@mesos.apache.org>
Subject Re: Review Request 62820: Added first class profile for disk resources.
Date Sat, 07 Oct 2017 05:36:19 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62820/#review187333
-----------------------------------------------------------



Patch looks great!

Reviews applied: [62818, 62819, 62820]

Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose
--disable-libtool-wrappers' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh

- Mesos Reviewbot


On Oct. 6, 2017, 9:42 p.m., Jie Yu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62820/
> -----------------------------------------------------------
> 
> (Updated Oct. 6, 2017, 9:42 p.m.)
> 
> 
> Review request for mesos, Benjamin Bannier, James DeFelice, and Joseph Wu.
> 
> 
> Bugs: MESOS-8060
>     https://issues.apache.org/jira/browse/MESOS-8060
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This is similar to storage classes. Instead of adding a bunch of
> storage backend specific parameters (e.g., rotational, type, speed,
> etc.) into the disk resources, and asking the frameworks to make
> scheduling decisions based on those vendor specific parameters. We
> propose to use a level of indirection here.
> 
> The operator will setup mappings between a profile name to a set of
> vendor specific disk parameters. The framework will do disk selection
> based on profile names.
> 
> The storage resource provider will provide a hook allowing operators
> to customize the profile name assignment for disk resources.
> 
> 
> Diffs
> -----
> 
>   include/mesos/mesos.proto 1bfcc5bb9091075c6fa1bc36e2cd23afe2e0e0ec 
>   include/mesos/v1/mesos.proto d742adbbf24692d2d82aad51316d767af93942d5 
>   src/common/resources.cpp ea0f3a28b55bc9e6b52bb2215b39a0f323396246 
>   src/tests/mesos.hpp b0749db273c91692b91d7ca87f975694b18e422c 
>   src/tests/resources_tests.cpp 7f0150ff04b2c5a9a0c47b29a107bad5e363285a 
>   src/v1/resources.cpp a64180bad1d782dd270e06217a389002155c2e10 
> 
> 
> Diff: https://reviews.apache.org/r/62820/diff/1/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Jie Yu
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message