mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Benjamin Mahler <bmah...@apache.org>
Subject Re: Review Request 61174: Added a test `ProtobufTest.ParseJSONUnrecognizedEnum`.
Date Fri, 29 Sep 2017 18:12:42 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61174/#review186707
-----------------------------------------------------------


Fix it, then Ship it!





3rdparty/stout/tests/protobuf_tests.cpp
Lines 423-425 (patched)
<https://reviews.apache.org/r/61174/#comment263502>

    Let's clarify that the field will be unset (similar to how this is handled by protobuf
de-serialization).


- Benjamin Mahler


On Sept. 29, 2017, 8:47 a.m., Qian Zhang wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61174/
> -----------------------------------------------------------
> 
> (Updated Sept. 29, 2017, 8:47 a.m.)
> 
> 
> Review request for mesos, Benjamin Mahler and James Peach.
> 
> 
> Bugs: MESOS-7828
>     https://issues.apache.org/jira/browse/MESOS-7828
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added a test `ProtobufTest.ParseJSONUnrecognizedEnum`.
> 
> 
> Diffs
> -----
> 
>   3rdparty/stout/tests/protobuf_tests.cpp 8877e8934e0f7875bfedcfa88b491ce4b13ca44f 
>   3rdparty/stout/tests/protobuf_tests.proto d16726aa8060aea2b830040b20dbdd467c801483

> 
> 
> Diff: https://reviews.apache.org/r/61174/diff/4/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Qian Zhang
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message