mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Greg Mann <g...@mesosphere.io>
Subject Re: Review Request 62587: Added HTTP authenticatee interface definition.
Date Wed, 27 Sep 2017 22:18:09 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62587/#review186470
-----------------------------------------------------------




include/mesos/authentication/http/authenticatee.hpp
Lines 41 (patched)
<https://reviews.apache.org/r/62587/#comment263022>

    s/token based/token-based/



include/mesos/authentication/http/authenticatee.hpp
Lines 42 (patched)
<https://reviews.apache.org/r/62587/#comment263023>

    s/May  get/May get/



include/mesos/authentication/http/authenticatee.hpp
Lines 45 (patched)
<https://reviews.apache.org/r/62587/#comment263034>

    Am I correct in thinking that this method is primarily intended to enable the client to
handle the case where requests fail authentication? If so, maybe we should call that out explicitly
in the comment.



include/mesos/authentication/http/authenticatee.hpp
Lines 49 (patched)
<https://reviews.apache.org/r/62587/#comment263035>

    s/authentication related/authentication-related/


- Greg Mann


On Sept. 26, 2017, 10:54 p.m., Till Toenshoff wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62587/
> -----------------------------------------------------------
> 
> (Updated Sept. 26, 2017, 10:54 p.m.)
> 
> 
> Review request for mesos, Armand Grillet, Benjamin Bannier, Greg Mann, and Kapil Arya.
> 
> 
> Bugs: MESOS-8016
>     https://issues.apache.org/jira/browse/MESOS-8016
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> see summary.
> 
> 
> Diffs
> -----
> 
>   include/mesos/authentication/http/authenticatee.hpp PRE-CREATION 
>   src/Makefile.am 93ed2bf55447e3e470d9bea8a0b61ce78aad1900 
> 
> 
> Diff: https://reviews.apache.org/r/62587/diff/1/
> 
> 
> Testing
> -------
> 
> Integration test in external project. Further tests upcoming.
> 
> 
> Thanks,
> 
> Till Toenshoff
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message