mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Kevin Klues <klue...@gmail.com>
Subject Re: Review Request 62067: Added 'mesos container list' command to CLI.
Date Wed, 27 Sep 2017 12:53:32 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62067/#review186401
-----------------------------------------------------------



I think we need to think a bit more about how we want to pass the agent id / address to this
command. We want to make sure it works in a generalized Mesos setup (without being opinionated
about the connectivity of agents in the cluster to the machine where the CLI is running).
As it stands now, this implementation assumes we have direct access to the agents from the
CLI and are able to hit their <ip:port> directly to access their API. Maybe a simple
`--proxy` flag with the URL to proxy API calls through would be sufficient (with a default
that can be set in the config). We will need to play around with this a bit more though before
deciding.

- Kevin Klues


On Sept. 27, 2017, 12:39 p.m., Armand Grillet wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62067/
> -----------------------------------------------------------
> 
> (Updated Sept. 27, 2017, 12:39 p.m.)
> 
> 
> Review request for mesos and Kevin Klues.
> 
> 
> Bugs: MESOS-7285
>     https://issues.apache.org/jira/browse/MESOS-7285
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This command displays the containers running
> on all the agents or a specific one.
> 
> 
> Diffs
> -----
> 
>   src/python/cli_new/bin/settings.py d42df04b0ff42bb6f466842e59223cd90a74d5c0 
>   src/python/cli_new/lib/cli/plugins/container/__init__.py PRE-CREATION 
>   src/python/cli_new/lib/cli/plugins/container/main.py PRE-CREATION 
>   src/python/cli_new/lib/cli/tests/__init__.py 0daf28869e107263c51653ace39e3b1826871048

>   src/python/cli_new/lib/cli/tests/container.py PRE-CREATION 
>   src/python/cli_new/tests/main.py 3e4d2e449a6485206700b4a490d325a393d31f90 
> 
> 
> Diff: https://reviews.apache.org/r/62067/diff/3/
> 
> 
> Testing
> -------
> 
> To test with one master:
> 
> $ ./bootstrap
> $ source activate
> $ mesos-cli-tests
> 
> I also checked that the Python linter was still working.
> 
> 
> Thanks,
> 
> Armand Grillet
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message