mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Kevin Klues <klue...@gmail.com>
Subject Re: Review Request 60088: CLI: Added 'master' key as an acceptable key in config.toml.
Date Tue, 26 Sep 2017 13:10:31 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60088/#review186245
-----------------------------------------------------------




src/python/cli_new/README.md
Lines 82 (patched)
<https://reviews.apache.org/r/60088/#comment262723>

    I would add a "For example:" here.



src/python/cli_new/lib/cli/config.py
Lines 54 (patched)
<https://reviews.apache.org/r/60088/#comment262724>

    We shouldn't need this anymore.



src/python/cli_new/lib/cli/config.py
Lines 58 (patched)
<https://reviews.apache.org/r/60088/#comment262725>

    We should probably pull this in from the constants file instead of hard coding it as a
string here.



src/python/cli_new/lib/cli/config.py
Lines 65 (patched)
<https://reviews.apache.org/r/60088/#comment262726>

    The indentation here seems wrong.



src/python/cli_new/lib/cli/config.py
Lines 67 (patched)
<https://reviews.apache.org/r/60088/#comment262728>

    One too many spaces here



src/python/cli_new/lib/cli/config.py
Lines 70 (patched)
<https://reviews.apache.org/r/60088/#comment262727>

    the indentation here seems wrong



src/python/cli_new/lib/cli/config.py
Lines 80 (patched)
<https://reviews.apache.org/r/60088/#comment262733>

    The 'master' address



src/python/cli_new/lib/cli/config.py
Lines 88 (patched)
<https://reviews.apache.org/r/60088/#comment262729>

    We need to first check if 'addresses' in 'zk_field' before we can index it.



src/python/cli_new/lib/cli/config.py
Lines 91 (patched)
<https://reviews.apache.org/r/60088/#comment262730>

    We need to first check if 'path' in 'zk_field' before we can index it.



src/python/cli_new/lib/cli/config.py
Lines 95 (patched)
<https://reviews.apache.org/r/60088/#comment262731>

    I think it's OK to start with a `/` it just can't be *only* `/'



src/python/cli_new/lib/cli/config.py
Lines 102 (patched)
<https://reviews.apache.org/r/60088/#comment262732>

    The 'zookeeper' address.



src/python/cli_new/lib/cli/config.py
Lines 111 (patched)
<https://reviews.apache.org/r/60088/#comment262734>

    s/leader/leading/


- Kevin Klues


On Sept. 25, 2017, 2:03 p.m., Armand Grillet wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60088/
> -----------------------------------------------------------
> 
> (Updated Sept. 25, 2017, 2:03 p.m.)
> 
> 
> Review request for mesos and Kevin Klues.
> 
> 
> Bugs: MESOS-7284
>     https://issues.apache.org/jira/browse/MESOS-7284
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This key is a field that has to be composed of
> an `address` or `zookeeper` field, but not both.
> 
> 
> Diffs
> -----
> 
>   src/python/cli_new/README.md c5475c7f4632fde5303ed1c901918d9088eac660 
>   src/python/cli_new/lib/cli/config.py 36a32f94bb12a033705b20f3c91d8bba972ba6c5 
>   src/python/cli_new/lib/cli/util.py 7371f83543ed527bea8dbf2fe4e20d92ef8e4492 
> 
> 
> Diff: https://reviews.apache.org/r/60088/diff/6/
> 
> 
> Testing
> -------
> 
> Tested manually, PEP8 and Pylint used to make sure that the code style is correct.
> 
> 
> Thanks,
> 
> Armand Grillet
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message