mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Ilya Pronin <>
Subject Re: Review Request 62285: Added tombstone flag to NOP log action.
Date Mon, 25 Sep 2017 13:05:37 GMT

This is an automatically generated e-mail. To reply, visit:

(Updated Sept. 25, 2017, 2:05 p.m.)

Review request for mesos and Jie Yu.


Addressed review comments.

Bugs: MESOS-7973

Repository: mesos


NOP action is used as a filler for holes in the "fill" procedure and as
the action in a response to a promise request for a truncated position.
The tombstone flag is introduced so that replicas are able to
distinguish the truncated action from a real NOP.

Diffs (updated)

  src/log/leveldb.cpp 5310a123b0fb25f240429722b676fe46174cb2ce 
  src/log/replica.cpp 39f2879b2e37c1ca9a9f987ce0a3b83e8dbc9b43 
  src/messages/log.proto ca740bd011147f8f48cc5dfcacefa5fdbd95ccd0 
  src/tests/log_tests.cpp f9f9400c901152779ae0ebfe74cf8f7aac1d3396 




Added a test that verifies that a replica correctly handles the tombstone NOP. Ran `make check`.


Ilya Pronin

  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message