mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Benjamin Bannier <>
Subject Review Request 62282: Fixed 'operator==' for 'Resource::DiskInfo::Source'.
Date Wed, 13 Sep 2017 15:23:15 GMT

This is an automatically generated e-mail. To reply, visit:

Review request for mesos, Jie Yu and Jan Schlicht.

Repository: mesos


When implementing 'operator==' for protobufs as a patter we typically
first check that two 'optional' fields are set for both the left- and
righthand side, and only then compare their values, e.g., given a

    message Foo {
      optional string bar = 1;

we would implement 'operator==' similar to the following,

   bool operator==(const Foo& lhs, const Foo& rhs)
       if (lhs.has_bar() != rhs.has_bar()) {
         return false;

       if ( != {
         return false;

       return true;

One reason for this is that it allows us to distinguish an unset field
from a set field containing a default constructed value (if e.g.,
above 'lhs.has_bar()' was 'false', '' would return an empty

This patch makes sure we use the same pattern when checking
'Resource::DiskInfo::Source' for equality.


  src/common/resources.cpp 14b600ca1577be4910164396c75b866b53439ade 



`make check`


Benjamin Bannier

  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message