mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Benjamin Bannier <benjamin.bann...@mesosphere.io>
Subject Re: Review Request 61182: Sent a resource provider message when providers subscribe.
Date Wed, 06 Sep 2017 12:00:03 GMT


> On Aug. 1, 2017, 12:48 a.m., Jie Yu wrote:
> > src/tests/resource_provider_manager_tests.cpp
> > Lines 134 (patched)
> > <https://reviews.apache.org/r/61182/diff/2/?file=1785926#file1785926line134>
> >
> >     In fact, what's the different between this and ResourceProviderHttpApiTest.Subscribe.
> >     
> >     My suggestion is:
> >     
> >     Let's move all resource provider manager related tests into a single test file
(resource_provider_manager_tests.cpp). Use different TestCase name to group them.
> >     
> >     For HTTP level tests (e.g., content type, accept type, etc.), call it ResourceProviderManagerHttpApiTest.
> >     
> >     For all the functional tests, use the manager interface directly (call it ResourceProviderManagerTest).

Agreed. I incorporated the changes into the existing test.


- Benjamin


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61182/#review181854
-----------------------------------------------------------


On Sept. 6, 2017, 1:59 p.m., Benjamin Bannier wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61182/
> -----------------------------------------------------------
> 
> (Updated Sept. 6, 2017, 1:59 p.m.)
> 
> 
> Review request for mesos, Jie Yu and Jan Schlicht.
> 
> 
> Bugs: MESOS-7837
>     https://issues.apache.org/jira/browse/MESOS-7837
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> In order to inform users of resource provider managers that the
> managed resources have changed, we add a new 'ResourceProviderMessage'
> type for communicating changes to the managed total resources.
> 
> We add code to trigger sending of that message when a resource
> provider subscribes with the manager.
> 
> In the future this message could also be used to communicate changes
> to an already subscribed resource provider's total resources.
> 
> 
> Diffs
> -----
> 
>   src/resource_provider/manager.cpp da9dff1e9bb18780ac5a5b25d2fd98e931da74af 
>   src/resource_provider/message.hpp 916926bf278de9ed919384a82a452d3ced06bd04 
>   src/tests/resource_provider_manager_tests.cpp 83a1340fa16b19e3297a8c0ca413afc312de00ec

> 
> 
> Diff: https://reviews.apache.org/r/61182/diff/4/
> 
> 
> Testing
> -------
> 
> `make check`
> 
> 
> Thanks,
> 
> Benjamin Bannier
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message