mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Joseph Wu <jos...@mesosphere.io>
Subject Re: Review Request 60546: Harden Mesos when building with cmake.
Date Tue, 05 Sep 2017 20:51:06 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60546/#review184580
-----------------------------------------------------------


Ship it!




I'm going to apply this review in spirit (because the CMake build was rewritten underneath
it).

I'll make the below changes before committing.


cmake/CompilationConfigure.cmake
Lines 202-212 (patched)
<https://reviews.apache.org/r/60546/#comment260749>

    Going to replace this:
    `set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} `
    
    With this:
    `string(APPEND CMAKE_CXX_FLAGS " `



cmake/CompilationConfigure.cmake
Lines 219-223 (patched)
<https://reviews.apache.org/r/60546/#comment260747>

    Going to replace this with the cross-platform equivalent:
    ```
    set(CMAKE_POSITION_INDEPENDENT_CODE TRUE)
    ```
    
    See: https://cmake.org/cmake/help/v3.0/prop_tgt/POSITION_INDEPENDENT_CODE.html



cmake/MesosConfigure.cmake
Lines 65-70 (patched)
<https://reviews.apache.org/r/60546/#comment260748>

    Ditto with above.


- Joseph Wu


On July 5, 2017, 9:06 a.m., Aaron Wood wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60546/
> -----------------------------------------------------------
> 
> (Updated July 5, 2017, 9:06 a.m.)
> 
> 
> Review request for mesos, Andrew Schwartzmeyer, Benjamin Bannier, and Joseph Wu.
> 
> 
> Bugs: MESOS-7737
>     https://issues.apache.org/jira/browse/MESOS-7737
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Apply stack protectors (stronger stack protectors with newer compilers), position independent
code suitable for linking into executables, security warnings, and generate position independent
executables.
> 
> 
> Diffs
> -----
> 
>   cmake/CompilationConfigure.cmake 3fa2e2f3b 
>   cmake/MesosConfigure.cmake 5ecad2c0f 
> 
> 
> Diff: https://reviews.apache.org/r/60546/diff/2/
> 
> 
> Testing
> -------
> 
> `mkdir build && cd build && cmake .. && make -j$(nproc) &&
make check -j$(nproc)`
> 
> 
> Thanks,
> 
> Aaron Wood
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message