mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Mesos Reviewbot Windows <revi...@mesos.apache.org>
Subject Re: Review Request 62067: CLI: Added 'mesos container list' command.
Date Tue, 05 Sep 2017 08:11:11 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62067/#review184514
-----------------------------------------------------------



Bad review!

Error:
Circular dependency detected for review 62067.Please fix the 'depends_on' field.

- Mesos Reviewbot Windows


On Sept. 4, 2017, 7:54 a.m., Armand Grillet wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62067/
> -----------------------------------------------------------
> 
> (Updated Sept. 4, 2017, 7:54 a.m.)
> 
> 
> Review request for mesos and Kevin Klues.
> 
> 
> Bugs: MESOS-7285
>     https://issues.apache.org/jira/browse/MESOS-7285
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This command displays the containers running
> on all the agents or a specific one.
> 
> 
> Diffs
> -----
> 
>   src/python/cli_new/bin/settings.py d42df04b0ff42bb6f466842e59223cd90a74d5c0 
>   src/python/cli_new/lib/cli/plugins/container/__init__.py PRE-CREATION 
>   src/python/cli_new/lib/cli/plugins/container/main.py PRE-CREATION 
>   src/python/cli_new/lib/cli/tests/__init__.py 0daf28869e107263c51653ace39e3b1826871048

>   src/python/cli_new/lib/cli/tests/container.py PRE-CREATION 
>   src/python/cli_new/tests/main.py 3e4d2e449a6485206700b4a490d325a393d31f90 
> 
> 
> Diff: https://reviews.apache.org/r/62067/diff/1/
> 
> 
> Testing
> -------
> 
> To test with one master:
> 
> $ ./bootstrap
> $ source activate
> $ mesos-cli-tests
> 
> 
> To test the command in High-Availability Mode I have:
> 1. Started ZooKeeper.
> 2. Started two masters using the flags --zk and --quorum.
> 3. Started one agent.
> 4. Launched one task using ./mesos-execute --master='zk://127.0.0.1:2181/mesos' --name='test'
--command='sleep 3600'.
> 5. Checked that the output of 'mesos container list' was correct.
> 
> I also checked that the Python linter was still working.
> 
> 
> Thanks,
> 
> Armand Grillet
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message