mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Benjamin Mahler <bmah...@apache.org>
Subject Re: Review Request 61640: Improved the reason and message for tasks killed before delivery.
Date Wed, 23 Aug 2017 19:00:18 GMT


> On Aug. 18, 2017, 11:37 p.m., Vinod Kone wrote:
> > src/slave/slave.cpp
> > Lines 3033 (patched)
> > <https://reviews.apache.org/r/61640/diff/1/?file=1797191#file1797191line3033>
> >
> >     Can you add a TODO to the protobuf that contains this enum saying that it is
no longer used.
> >     
> >     Also, should we use a better named enum for this case? I would like to move
towards all mesos generated updates to have reasons.

Introduced a `REASON_TASK_KILLED_BEFORE_DELIVERY` for these cases and updated the master side
as well.


- Benjamin


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61640/#review183281
-----------------------------------------------------------


On Aug. 22, 2017, 7:45 p.m., Benjamin Mahler wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61640/
> -----------------------------------------------------------
> 
> (Updated Aug. 22, 2017, 7:45 p.m.)
> 
> 
> Review request for mesos, Anand Mazumdar and Vinod Kone.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Previously, if a task was killed before delivery to a registering
> executor, we sent REASON_EXECUTOR_UNREGISTERED with a message of
> "Unregistered executor" in the agent, and the master sent no reason.
> This introduces a REASON_TASK_KILLED_BEFORE_DELIVERY to clarify
> this case to frameworks.
> 
> 
> Diffs
> -----
> 
>   include/mesos/mesos.proto d91c96814dfcd03a4390d80f90acd61b5e4aebdd 
>   include/mesos/v1/mesos.proto 6a1d011a45dcead644300d6becedcbd4bc1f5a96 
>   src/master/master.cpp 7f38a5e21884546d4b4c866ca5918db779af8f99 
>   src/slave/slave.cpp 50d2a10cd68f6611efd4e691e5325e6e0c06f33a 
>   src/tests/master_authorization_tests.cpp b41b4a111a51f1b7f774334d5867528f007adaff 
>   src/tests/slave_recovery_tests.cpp b3825d13b12ee0da110b30baba5f5e68051b8e97 
>   src/tests/slave_tests.cpp a8b46a450c4f3986139390aeed5544e7f9091781 
> 
> 
> Diff: https://reviews.apache.org/r/61640/diff/2/
> 
> 
> Testing
> -------
> 
> Updated the tests.
> 
> 
> Thanks,
> 
> Benjamin Mahler
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message