mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Benjamin Mahler <bmah...@apache.org>
Subject Re: Review Request 61640: Improved the reason and message for tasks killed before delivery.
Date Tue, 22 Aug 2017 19:45:33 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61640/
-----------------------------------------------------------

(Updated Aug. 22, 2017, 7:45 p.m.)


Review request for mesos, Anand Mazumdar and Vinod Kone.


Changes
-------

* Rebased
* Marked the old reason as no longer used
* Introduced a `REASON_TASK_KILLED_BEFORE_DELIVERY`


Summary (updated)
-----------------

Improved the reason and message for tasks killed before delivery.


Repository: mesos


Description (updated)
-------

Previously, if a task was killed before delivery to a registering
executor, we sent REASON_EXECUTOR_UNREGISTERED with a message of
"Unregistered executor" in the agent, and the master sent no reason.
This introduces a REASON_TASK_KILLED_BEFORE_DELIVERY to clarify
this case to frameworks.


Diffs (updated)
-----

  include/mesos/mesos.proto d91c96814dfcd03a4390d80f90acd61b5e4aebdd 
  include/mesos/v1/mesos.proto 6a1d011a45dcead644300d6becedcbd4bc1f5a96 
  src/master/master.cpp 7f38a5e21884546d4b4c866ca5918db779af8f99 
  src/slave/slave.cpp 50d2a10cd68f6611efd4e691e5325e6e0c06f33a 
  src/tests/master_authorization_tests.cpp b41b4a111a51f1b7f774334d5867528f007adaff 
  src/tests/slave_recovery_tests.cpp b3825d13b12ee0da110b30baba5f5e68051b8e97 
  src/tests/slave_tests.cpp a8b46a450c4f3986139390aeed5544e7f9091781 


Diff: https://reviews.apache.org/r/61640/diff/2/

Changes: https://reviews.apache.org/r/61640/diff/1-2/


Testing
-------

Updated the tests.


Thanks,

Benjamin Mahler


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message