mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Andrew Schwartzmeyer <and...@schwartzmeyer.com>
Subject Re: Review Request 60624: Enable HDFS compilation and associated tests.
Date Tue, 15 Aug 2017 18:11:40 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60624/#review182972
-----------------------------------------------------------




src/CMakeLists.txt
Line 513 (original), 514 (patched)
<https://reviews.apache.org/r/60624/#comment258942>

    Uh.



src/launcher/fetcher.cpp
Lines 267 (patched)
<https://reviews.apache.org/r/60624/#comment258943>

    This one is straight-forward. On Windows, there is no "executable permissions" so we can
simply ignore this logic. With a note of course as to why.



src/launcher/fetcher.cpp
Lines 487 (patched)
<https://reviews.apache.org/r/60624/#comment258946>

    I'm not suggesting to do this _right now_. But for `chown`, Windows has a mappable concept
of taking (probably recursive) ownership of the directory as the specified user. So we can
handle this, we'll just need to implement it.



src/launcher/fetcher.cpp
Lines 564 (patched)
<https://reviews.apache.org/r/60624/#comment258947>

    I think we can do the same thing as `os::su` with Windows user impersonation. It's a mappable
concept.



src/tests/hdfs_tests.cpp
Lines 56 (patched)
<https://reviews.apache.org/r/60624/#comment258949>

    Like above, we can safely ignore setting execution permission on Windows. My reasoning
is that the concept maps to nothing. So doing nothing is appropriate I think.


- Andrew Schwartzmeyer


On July 3, 2017, 12:32 p.m., Jeff Coffler wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60624/
> -----------------------------------------------------------
> 
> (Updated July 3, 2017, 12:32 p.m.)
> 
> 
> Review request for mesos, Andrew Schwartzmeyer, John Kordich, Joseph Wu, and Li Li.
> 
> 
> Bugs: MESOS-6705
>     https://issues.apache.org/jira/browse/MESOS-6705
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Note that tests are disabled for Windows due to dependence on 'sh'
> shell.
> 
> 
> Diffs
> -----
> 
>   src/CMakeLists.txt 51b67428f823454665db695ba70a0dc896a7595c 
>   src/launcher/fetcher.cpp 42980f5a4a40b72f754156469e9fe60a952d1d87 
>   src/tests/CMakeLists.txt 9c0acaf43f451dbc9ba5077529a36aa4cef40c34 
>   src/tests/hdfs_tests.cpp e7154c75e663d9a98bec48be42a59b65c96f9515 
> 
> 
> Diff: https://reviews.apache.org/r/60624/diff/1/
> 
> 
> Testing
> -------
> 
> See upstream
> 
> 
> Thanks,
> 
> Jeff Coffler
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message