mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Andrew Schwartzmeyer <and...@schwartzmeyer.com>
Subject Re: Review Request 61334: Imported `http_parser` library.
Date Thu, 10 Aug 2017 02:55:45 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61334/
-----------------------------------------------------------

(Updated Aug. 9, 2017, 7:55 p.m.)


Review request for mesos.


Changes
-------

The `UPDATE` command is unconditionally run, causing what appears to break incremental builds.
It causes the install step (a noop) to be repeated, but that updates the target, and so causes
libprocess to be relinked and so forth. The patch command is run once and only once, and really,
what we're doing here (adding a file to the source tree) _is_ patching the source tree.


Repository: mesos


Description (updated)
-------

Review: https://reviews.apache.org/r/61334


Diffs (updated)
-----

  3rdparty/CMakeLists.txt f4feaf90b4750338cfa2127524a5e6556a86d063 


Diff: https://reviews.apache.org/r/61334/diff/2/

Changes: https://reviews.apache.org/r/61334/diff/1-2/


Testing
-------


Thanks,

Andrew Schwartzmeyer


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message