mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Chun-Hung Hsiao <>
Subject Re: Review Request 61433: Refactored OpenSSL library checks in Mesos.
Date Wed, 09 Aug 2017 22:46:30 GMT

This is an automatically generated e-mail. To reply, visit:

(Updated Aug. 9, 2017, 10:46 p.m.)

Review request for mesos, Benjamin Bannier, Jie Yu, and Till Toenshoff.


Addressed @bbannier's comments.

Bugs: MESOS-7870

Repository: mesos


Since gRPC requires OpenSSL, we checks if libssl and libcrypto exist no
matter if the `--enable-ssl` flag is on. This enables us to have a
non-SSL-enabled Mesos build with gRPC support. Also fixed errors that
a bad linker might link the configure tests with libssl unnecessarily,
which would cause runtime failures if libssl is not in the runtime
library search path.

Diffs (updated)
----- 5a6e42c61e6752c3742532502dbc753071b31323 




Ran `make check` on the following two configurations:
1. ../configure
2. ../configure --enable-ssl --enable-libevent


Chun-Hung Hsiao

  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message