mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Chun-Hung Hsiao <>
Subject Re: Review Request 61098: Added unit tests for gRPC support in libprocess.
Date Thu, 27 Jul 2017 22:26:10 GMT

This is an automatically generated e-mail. To reply, visit:

(Updated July 27, 2017, 10:26 p.m.)

Review request for mesos, Benjamin Mahler, Jie Yu, and Joseph Wu.


Updated based on the changes in r/61097.

Bugs: MESOS-7810

Repository: mesos


We tested the following 6 scenarios when making gRPC calls:

1. The server responds with an OK.
2. The server responds with a failure.
3. The client discards the calls.
4. The client makes mulitple outstanding calls.
5. The client shuts down during a call.
6. The server is unreachable.
7. The server dose not respond in time.

`grpc_tests.pb.h`, ``, `grpc_tests.grpc.pb.h` and
`` are created with protobuf 3.3.0 and grpc
1.4.2 through the following command, assuming the current working
directory is `3rdparty/libprocess/src/tests`:
$ /path/to/protoc -I. --cpp_out=. --grpc_out=. \
  --plugin=protoc-gen-grpc=/path/to/grpc_cpp_plugin \

Diffs (updated)

  3rdparty/libprocess/src/tests/grpc_tests.cpp PRE-CREATION 
  3rdparty/libprocess/src/tests/grpc_tests.grpc.pb.h PRE-CREATION 
  3rdparty/libprocess/src/tests/ PRE-CREATION 
  3rdparty/libprocess/src/tests/grpc_tests.pb.h PRE-CREATION 
  3rdparty/libprocess/src/tests/ PRE-CREATION 
  3rdparty/libprocess/src/tests/grpc_tests.proto PRE-CREATION 






Chun-Hung Hsiao

  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message