mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From James Peach <>
Subject Review Request 60958: Made the metrics::Timer time window argument compulsory.
Date Wed, 19 Jul 2017 09:03:47 GMT

This is an automatically generated e-mail. To reply, visit:

Review request for mesos, Benjamin Mahler, Kevin Klues, and Jiang Yan Xu.

Bugs: MESOS-6918

Repository: mesos


If Timer metrics don't have a time window, then just store the last
sampled duration. Since you can't meaningfully graph this (you don't
know when it changed), make the time window compulsory so that we
can always calculate TimeWindow statistics.


  3rdparty/libprocess/include/process/metrics/timer.hpp 0a9c0227c457c6c81a59f65f901a5464ee00983d



make check


James Peach

  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message