mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Qian Zhang <zhq527...@gmail.com>
Subject Re: Review Request 60902: Moved the libnl3 configure checks into a macro.
Date Mon, 17 Jul 2017 03:20:21 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60902/#review180653
-----------------------------------------------------------




configure.ac
Line 350 (original)
<https://reviews.apache.org/r/60902/#comment255845>

    So `--with-nl` is removed, will it cause backward compatibility issue?



configure.ac
Line 1297 (original), 1285 (patched)
<https://reviews.apache.org/r/60902/#comment255846>

    Do you want to change `network isolator` to `port mapping isolator` too?



m4/libnl3.m4
Lines 33-37 (patched)
<https://reviews.apache.org/r/60902/#comment255847>

    Mind to elaborate a bit about why introducing a new .m4 file? What about just introducing
a new configure option (like `--enable-libnl3`) and make `--enable_port_mapping_isolator`
depend on it? Just like the relationship between `--enable-ssl` and `--enable-libevent`: https://github.com/apache/mesos/blob/1.3.0/configure.ac#L1657:L1698
    
    And for `--enable-libnl3`, I think we should not do much checks, just some very basic
check should be OK, and on top of it, `--enable_port_mapping_isolator` can do some more advanced/specific
check on libnl3 for itself.


- Qian Zhang


On July 17, 2017, 7:43 a.m., James Peach wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60902/
> -----------------------------------------------------------
> 
> (Updated July 17, 2017, 7:43 a.m.)
> 
> 
> Review request for mesos and Qian Zhang.
> 
> 
> Bugs: MESOS-7675
>     https://issues.apache.org/jira/browse/MESOS-7675
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Since the `network/ports` isolator will depend on libnl3, move those
> checks into a separate macro so that we can call it again when we
> add a configure option to enable it.
> 
> 
> Diffs
> -----
> 
>   configure.ac 4d7c4a4679e5c624ee750226d542e0d8c228507a 
>   m4/libnl3.m4 PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/60902/diff/1/
> 
> 
> Testing
> -------
> 
> make check (Fedora 26), manual verification of configuration logs.
> 
> 
> Thanks,
> 
> James Peach
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message