mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Quinn Leng <>
Subject Re: Review Request 60580: Added filtering to the '/frameworks' endpoint.
Date Wed, 12 Jul 2017 18:19:23 GMT

This is an automatically generated e-mail. To reply, visit:

(Updated July 12, 2017, 6:19 p.m.)

Review request for mesos, Anand Mazumdar, Alexander Rojas, Greg Mann, and Vinod Kone.

Bugs: MESOS-7630

Repository: mesos


Added filtering to the '/frameworks' endpoint.

Add query parameter support for '/frameworks' endpoint.
To query the information about a specific framework, we
can use 'framework_id' to specify the framework, thus it
looks like'/frameworks?framework_id=[framework id]'

To maintain consistency, the structure for response is
reserved, thus the response still contains field 'frameworks'
and 'completed_frameworks' etc..

Since code for '/state' endpoint and '/frameworks' are coupled
(they share 'FullFrameworkWriter' class), thus the code for '/state'
endpoint is also updated.

Diffs (updated)

  src/master/http.cpp 948aa118101b6ce03410c9e0c945b6ca16668ca2 
  src/tests/master_tests.cpp 6e6461c2e13c3eb055aa3c2d8ad8e3ac54a1d197 




Passed 'make check -j48'
Passed 'GTEST_FILTER="MasterTest.FrameworksEndpointQueryFramework" make check -j48'
Passed 'GLOG_v=1 ./bin/ --gtest_filter="MasterTest.FrameworksEndpointQueryFramework"
--gtest_repeat=1000 --gtest_break_on_failure'


Quinn Leng

  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message